Skip to content

sriov: bump golang to 1.25#8776

Open
zeeke wants to merge 1 commit intoopenshift-eng:openshift-4.22from
zeeke:sriov-422-golang-1-25
Open

sriov: bump golang to 1.25#8776
zeeke wants to merge 1 commit intoopenshift-eng:openshift-4.22from
zeeke:sriov-422-golang-1-25

Conversation

@zeeke
Copy link

@zeeke zeeke commented Jan 28, 2026

Image stream rhel-9-golang ships go.124 by default. SR-IOV projects have been bumped to go1.25 upstream.

Move builder images to rhel-9-golang-1.25 in the openshift-4.22 branch. Newer branches don't need any change, as the GO_LATEST version is already > 1.25

Links:

sample failed builds:

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 28, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 28, 2026

Hi @zeeke. Thanks for your PR.

I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zeeke,
thanks for helping me with this PR!

I think you are missing two here

  1. ib-sriov-cni
  2. sriov-network-mitrics-exporter

Image stream `rhel-9-golang` ships go.124  by default.
SR-IOV projects have been bumped to go1.25 upstream.

Move builder images to `rhel-9-golang-1.25` in the openshift-4.22 branch.
Newer branches don't need any change, as the `GO_LATEST` version is already > 1.25

Links:
- k8snetworkplumbingwg/sriov-network-operator#1002
- k8snetworkplumbingwg/sriov-network-device-plugin#690

Signed-off-by: Andrea Panattoni <apanatto@redhat.com>
@zeeke zeeke force-pushed the sriov-422-golang-1-25 branch from b7fc428 to cb19334 Compare February 2, 2026 08:52
@zeeke
Copy link
Author

zeeke commented Feb 2, 2026

Hi @zeeke, thanks for helping me with this PR!

I think you are missing two here

  1. ib-sriov-cni
  2. sriov-network-mitrics-exporter

you're right! I added those repos to the changes

Copy link

@SchSeba SchSeba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

@SchSeba: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SchSeba
Once this PR has been reviewed and has the lgtm label, please assign namansharma18899 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zeeke
Copy link
Author

zeeke commented Feb 9, 2026

@Ximinhan @joepvd @namansharma18899 please take a look at this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants