Skip to content

Conversation

@dtrifiro
Copy link
Collaborator

@dtrifiro dtrifiro commented Nov 12, 2025

Using lm-eval==0.4.8 causes our workflows with the vllm backend (vllm~=0.11.0) to fail, possibly due to V0 deprecation (deprecatred arguments being passed to the engine).

Switching to 0.4.9.1 solves the issue.

This PR also bumps package version from 0.4.0 to 0.4.1

Summary by CodeRabbit

  • Chores
    • Bumped project version to 0.4.1.
    • Updated lm-eval dependency to a newer patch release for improved stability and performance.

@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Walkthrough

Bumped project version from 0.4.0 to 0.4.1 and updated the lm-eval[api] dependency from 0.4.8 to 0.4.9.1 in pyproject.toml. No other files, exports, or configurations were modified.

Changes

Cohort / File(s) Change Summary
Project config
pyproject.toml
Bumped project version 0.4.00.4.1 and updated dependency lm-eval[api] 0.4.80.4.9.1

Sequence Diagram(s)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Focus review on pyproject.toml to confirm version and dependency syntax.

Poem

🐰 A hop, a bump, the versions align,
0.4.0 to 0.4.1 — tidy and fine.
lm-eval steps up, a gentle new tune,
I nibble the change and hum a soft tune. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change in the pull request, which is bumping the lm-eval dependency to version 0.4.9.1.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53f82ad and aaaa8b5.

📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • pyproject.toml

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@sjmonson sjmonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test all the task to make sure they are compatible with the new version.

@dtrifiro
Copy link
Collaborator Author

Thanks, I'll let you merge this when you're sure everything works.

@dtrifiro dtrifiro merged commit 5d587bc into openshift-psap:main Nov 13, 2025
2 checks passed
@dtrifiro dtrifiro deleted the bump-lm-eval branch November 13, 2025 22:48
@coderabbitai coderabbitai bot mentioned this pull request Jan 19, 2026
@coderabbitai coderabbitai bot mentioned this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants