Skip to content

Reduce noise from MachineOutOfCompliance alerts #2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dustman9000 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reduce noise from MachineOutOfCompliance alerts #2604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions deploy/sre-prometheus/management-cluster/100-machine-out-of-compliance.PrometheusRule.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,29 @@ spec:
groups:
- name: sre-machine-out-of-compliance
rules:
# Critical alert for machines truly stuck (>35 days = clear failure)
- alert: MachineOutOfComplianceSRE
# https://issues.redhat.com/browse/OSD-17905
# This alert is a fallback in case the workload in https://issues.redhat.com/browse/OSD-17902 doesn't do it's job.
expr: (time() - mapi_machine_created_timestamp_seconds) > 2419200
for: 60m
# Fires when ANY machine exceeds 35 days old, indicating compliance-monkey failed to replace it.
expr: (time() - mapi_machine_created_timestamp_seconds) > 3024000
Copy link
Contributor

@joshbranham joshbranham Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a requirement where we need to replace machines older than 28 days, which means that firing at 35 means we are out of compliance?

for: 1h
labels:
severity: critical
namespace: "{{ $labels.namespace }}"
node: "{{ $labels.node }}"
link: "https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md"
annotations:
message: A machine on a management cluster is older than 28 days.
message: A machine on a management cluster is older than 35 days, indicating a compliance-monkey failure.
# Warning alert for queue backlogs (multiple machines aging out simultaneously)
- alert: MachineOutOfComplianceSREWarning
# https://issues.redhat.com/browse/OSD-17905
# Fires when multiple machines are >28 days old, indicating compliance-monkey queue backup.
# This is expected when many machines age out simultaneously but warrants monitoring.
expr: count((time() - mapi_machine_created_timestamp_seconds) > 2419200) > 5
for: 4h
labels:
severity: warning
link: "https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md"
annotations:
message: "{{ $value }} machines on a management cluster are older than 28 days, indicating a compliance-monkey queue backup."
17 changes: 14 additions & 3 deletions hack/00-osd-managed-cluster-config-integration.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49076,15 +49076,26 @@ objects:
- name: sre-machine-out-of-compliance
rules:
- alert: MachineOutOfComplianceSRE
expr: (time() - mapi_machine_created_timestamp_seconds) > 2419200
for: 60m
expr: (time() - mapi_machine_created_timestamp_seconds) > 3024000
for: 1h
labels:
severity: critical
namespace: '{{ $labels.namespace }}'
node: '{{ $labels.node }}'
link: https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md
annotations:
message: A machine on a management cluster is older than 28 days.
message: A machine on a management cluster is older than 35 days, indicating
a compliance-monkey failure.
- alert: MachineOutOfComplianceSREWarning
expr: count((time() - mapi_machine_created_timestamp_seconds) > 2419200)
> 5
for: 4h
labels:
severity: warning
link: https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md
annotations:
message: '{{ $value }} machines on a management cluster are older than
28 days, indicating a compliance-monkey queue backup.'
- apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
Expand Down
17 changes: 14 additions & 3 deletions hack/00-osd-managed-cluster-config-production.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49076,15 +49076,26 @@ objects:
- name: sre-machine-out-of-compliance
rules:
- alert: MachineOutOfComplianceSRE
expr: (time() - mapi_machine_created_timestamp_seconds) > 2419200
for: 60m
expr: (time() - mapi_machine_created_timestamp_seconds) > 3024000
for: 1h
labels:
severity: critical
namespace: '{{ $labels.namespace }}'
node: '{{ $labels.node }}'
link: https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md
annotations:
message: A machine on a management cluster is older than 28 days.
message: A machine on a management cluster is older than 35 days, indicating
a compliance-monkey failure.
- alert: MachineOutOfComplianceSREWarning
expr: count((time() - mapi_machine_created_timestamp_seconds) > 2419200)
> 5
for: 4h
labels:
severity: warning
link: https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md
annotations:
message: '{{ $value }} machines on a management cluster are older than
28 days, indicating a compliance-monkey queue backup.'
- apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
Expand Down
17 changes: 14 additions & 3 deletions hack/00-osd-managed-cluster-config-stage.yaml.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49076,15 +49076,26 @@ objects:
- name: sre-machine-out-of-compliance
rules:
- alert: MachineOutOfComplianceSRE
expr: (time() - mapi_machine_created_timestamp_seconds) > 2419200
for: 60m
expr: (time() - mapi_machine_created_timestamp_seconds) > 3024000
for: 1h
labels:
severity: critical
namespace: '{{ $labels.namespace }}'
node: '{{ $labels.node }}'
link: https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md
annotations:
message: A machine on a management cluster is older than 28 days.
message: A machine on a management cluster is older than 35 days, indicating
a compliance-monkey failure.
- alert: MachineOutOfComplianceSREWarning
expr: count((time() - mapi_machine_created_timestamp_seconds) > 2419200)
> 5
for: 4h
labels:
severity: warning
link: https://github.com/openshift/ops-sop/blob/master/v4/alerts/hypershift/MachineOutOfCompliance.md
annotations:
message: '{{ $value }} machines on a management cluster are older than
28 days, indicating a compliance-monkey queue backup.'
- apiVersion: monitoring.coreos.com/v1
kind: PrometheusRule
metadata:
Expand Down