Add new servicelog template for customer webhooks blocking nodepool upgrade#405
Open
tnierman wants to merge 1 commit intoopenshift:masterfrom
Open
Add new servicelog template for customer webhooks blocking nodepool upgrade#405tnierman wants to merge 1 commit intoopenshift:masterfrom
tnierman wants to merge 1 commit intoopenshift:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geowa4, tnierman The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
tnierman
force-pushed
the
add_nodepool-blocked-by-webhook_notification
branch
from
4222f0c to
86cb852
Compare
Contributor
|
New changes are detected. LGTM label has been removed. |
tnierman
force-pushed
the
add_nodepool-blocked-by-webhook_notification
branch
2 times, most recently
from
4326d2b to
25a933d
Compare
tnierman
force-pushed
the
add_nodepool-blocked-by-webhook_notification
branch
from
25a933d to
3229471
Compare
Contributor
|
@tnierman: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Customer webhooks can impact an HCP cluster's ability to upgrade nodepools in a timely matter, which can cause
HCPNodepoolUpgradeDelayalerts. This adds a template asking the customer to review their webhook configuration in this context