Skip to content

NO-JIRA: simplify dockerfile by removing cachito dependencies#799

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
lgarciaaco:chore/ocpbugs-77649-simplify-dockerfile-build
Mar 4, 2026
Merged

NO-JIRA: simplify dockerfile by removing cachito dependencies#799
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
lgarciaaco:chore/ocpbugs-77649-simplify-dockerfile-build

Conversation

@lgarciaaco
Copy link
Contributor

@lgarciaaco lgarciaaco commented Mar 3, 2026

Summary

OCPBUGS-77649: simplify dockerfile by removing cachito dependencies

Changes

Remove Cachito gomod dependencies handling and streamline the build process
to use direct make commands for frontend installation and building.

Summary by CodeRabbit

  • Chores
    • Simplified Docker build for the web frontend by replacing a multi-step dependency setup with a single environment flag and unified build step.
    • Clarified backend Docker build to include explicit source copy, working-directory setup, environment adjustments for strict FIPS runtime and native linking, and a dedicated backend build step.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Mar 3, 2026
@openshift-ci-robot
Copy link

@lgarciaaco: This pull request references Jira Issue OCPBUGS-77649, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gouyang

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

OCPBUGS-77649: simplify dockerfile by removing cachito dependencies

Changes

Remove Cachito gomod dependencies handling and streamline the build process
to use direct make commands for frontend installation and building.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from etmurasaki, gouyang and zhuje March 3, 2026 09:20
@openshift-ci-robot
Copy link

@lgarciaaco: This pull request references Jira Issue OCPBUGS-77649, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gouyang

Details

In response to this:

Summary

OCPBUGS-77649: simplify dockerfile by removing cachito dependencies

Changes

Remove Cachito gomod dependencies handling and streamline the build process
to use direct make commands for frontend installation and building.

Summary by CodeRabbit

  • Chores
  • Streamlined build process in Docker configuration for improved efficiency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 0508fed and 84d14fd.

📒 Files selected for processing (1)
  • Dockerfile.art
🚧 Files skipped from review as they are similar to previous changes (1)
  • Dockerfile.art

📝 Walkthrough

Walkthrough

Replaced Cachito multi-step dependency setup in Dockerfile.art with environment flag and consolidated frontend steps; added explicit backend build steps in the go-builder stage (source copy, working dir, GOEXPERIMENT/CGO_ENABLED, sourcing cachito.env, and BUILD_OPTS="-tags strictfipsruntime").

Changes

Cohort / File(s) Summary
Docker Build Configuration
Dockerfile.art
Web-builder: removed multi-step Cachito dependency setup and replaced with ENV CYPRESS_INSTALL_BINARY=0 plus a single RUN calling make install-frontend-ci and make build-frontend. Go-builder: added copying sources, WORKDIR to Cachito app path, GOEXPERIMENT=strictfipsruntime and CGO_ENABLED=1, sourcing cachito.env, and backend build with BUILD_OPTS="-tags strictfipsruntime".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐇 I nibble at Dockerfiles by lamplight,
I stitch envs and builds till they’re tight,
Frontend in two, backend in line,
Tags and vars set—how fine!
Hop, build, and ship — what a sight! 🚀

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: simplifying the Dockerfile by removing Cachito dependencies, which aligns with both the raw summary and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@lgarciaaco
Copy link
Contributor Author

/retest

@lgarciaaco lgarciaaco changed the title OCPBUGS-77649: simplify dockerfile by removing cachito dependencies NO-JIRA: simplify dockerfile by removing cachito dependencies Mar 3, 2026
@openshift-ci-robot openshift-ci-robot removed the jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. label Mar 3, 2026
@openshift-ci-robot
Copy link

@lgarciaaco: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

OCPBUGS-77649: simplify dockerfile by removing cachito dependencies

Changes

Remove Cachito gomod dependencies handling and streamline the build process
to use direct make commands for frontend installation and building.

Summary by CodeRabbit

  • Chores
  • Streamlined build process in Docker configuration for improved efficiency.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Mar 3, 2026
Remove Cachito gomod dependencies handling and streamline the build process
to use direct make commands for frontend installation and building.
@lgarciaaco lgarciaaco force-pushed the chore/ocpbugs-77649-simplify-dockerfile-build branch from 0508fed to 84d14fd Compare March 3, 2026 10:39
@jgbernalp
Copy link
Contributor

/retest

1 similar comment
@lgarciaaco
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@lgarciaaco: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm

@jgbernalp
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 4, 2026
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, lgarciaaco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 925053f into openshift:main Mar 4, 2026
9 checks passed
@lgarciaaco
Copy link
Contributor Author

/cherry-pick release-4.21
/cherry-pick release-4.20
/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

@openshift-cherrypick-robot

@lgarciaaco: #799 failed to apply on top of branch "release-4.17":

Applying: chore(build): simplify frontend build in Dockerfile.art
Using index info to reconstruct a base tree...
M	Dockerfile.art
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.art
CONFLICT (content): Merge conflict in Dockerfile.art
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 chore(build): simplify frontend build in Dockerfile.art

Details

In response to this:

/cherry-pick release-4.21
/cherry-pick release-4.20
/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lgarciaaco: new pull request created: #805

Details

In response to this:

/cherry-pick release-4.21
/cherry-pick release-4.20
/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lgarciaaco: new pull request created: #806

Details

In response to this:

/cherry-pick release-4.21
/cherry-pick release-4.20
/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lgarciaaco: new pull request created: #807

Details

In response to this:

/cherry-pick release-4.21
/cherry-pick release-4.20
/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

@lgarciaaco: #799 failed to apply on top of branch "release-4.21":

Applying: chore(build): simplify frontend build in Dockerfile.art
Using index info to reconstruct a base tree...
M	Dockerfile.art
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.art
CONFLICT (content): Merge conflict in Dockerfile.art
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 chore(build): simplify frontend build in Dockerfile.art

Details

In response to this:

/cherry-pick release-4.21
/cherry-pick release-4.20
/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants