Skip to content

OU-1261: [release-coo-0.4] fix: allow to fallback to global datasource if no local datasource is found#816

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-coo-0.4from
jgbernalp:fix-global-datasource-fallback-0.4
Mar 5, 2026
Merged

OU-1261: [release-coo-0.4] fix: allow to fallback to global datasource if no local datasource is found#816
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-coo-0.4from
jgbernalp:fix-global-datasource-fallback-0.4

Conversation

@jgbernalp
Copy link
Contributor

@jgbernalp jgbernalp commented Mar 5, 2026

Testing image:

quay.io/gbernal/monitoring-console-plugin:v0.4.4-global-ds

… found

Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@jgbernalp: This pull request references OU-1261 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 2cb2200a-0a91-4408-bf91-f6dd017e5b9c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@jgbernalp: This pull request references OU-1261 which is a valid jira issue.

Details

In response to this:

Testing image:

quay.io/gbernal/monitoring-console-plugin:v0.4.4-global-ds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jgbernalp
Copy link
Contributor Author

/override ci/prow/e2e-hypershift-conformance

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

@jgbernalp: Overrode contexts on behalf of jgbernalp: ci/prow/e2e-hypershift-conformance

Details

In response to this:

/override ci/prow/e2e-hypershift-conformance

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@etmurasaki
Copy link
Contributor

used quay.io/rh-ee-emurasak/monitoring-console-plugin:v0.4.4-global and worked fine.

apiVersion: perses.dev/v1alpha2
kind: PersesGlobalDatasource
metadata:
 name: loki-datasource
spec:
 config:
   display:
     name: "Loki Datasource (Application Logs)"
   default: true
   plugin:
     kind: "LokiDatasource"
     spec:
       proxy:
         kind: HTTPProxy
         spec:
           # URL structure for LokiStack with openshift-logging tenancy:
           # https://{gateway-svc}.{ns}.svc:8080/api/logs/v1/{tenant}
           # Perses will append /loki/api/v1/... for queries
           url: https://logging-loki-gateway-http.openshift-logging.svc.cluster.local:8080/api/logs/v1/application
           headers:
             X-Scope-OrgID: application
           # IMPORTANT: Must reference secret for TLS config
           secret: loki-datasource-secret
 client:
   tls:
     enable: true
     caCert:
       type: file
       certPath: /ca/service-ca.crt

and

apiVersion: perses.dev/v1alpha2
kind: PersesGlobalDatasource
metadata:
  name: tempo-platform
spec:
  config:
    display:
      name: "Tempo Datasource"
    default: true
    plugin:
      kind: "TempoDatasource"
      spec:
        proxy:
          kind: HTTPProxy
          spec:
            url: https://tempo-platform-gateway.openshift-tracing.svc.cluster.local:8080/api/traces/v1/platform/tempo
            headers:
              X-Scope-OrgID: platform
            secret: tempo-platform-secret
  client:
    tls:
      enable: true
      caCert:
        type: file
        certPath: /ca/service-ca.crt

@etmurasaki
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@jgbernalp: This pull request references OU-1261 which is a valid jira issue.

Details

In response to this:

Testing image:

quay.io/gbernal/monitoring-console-plugin:v0.4.4-global-ds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

@jgbernalp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift-conformance 00b5f2f link false /test e2e-hypershift-conformance

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 65692b9 into openshift:release-coo-0.4 Mar 5, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants