Skip to content

OU-1242: dont autofill rename#820

Open
PeterYurkovich wants to merge 1 commit intoopenshift:mainfrom
PeterYurkovich:forward-port-bug
Open

OU-1242: dont autofill rename#820
PeterYurkovich wants to merge 1 commit intoopenshift:mainfrom
PeterYurkovich:forward-port-bug

Conversation

@PeterYurkovich
Copy link
Contributor

@PeterYurkovich PeterYurkovich commented Mar 5, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Fixed dashboard rename behavior so closing the rename dialog reliably clears the name field to an empty value instead of restoring previous input.
  • Chores

    • Minor internal cleanups with no change to public APIs or user-visible functionality.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@PeterYurkovich: This pull request references OU-1242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@PeterYurkovich PeterYurkovich changed the title OU-1242: forward port dont autofill rename OU-1242: dont autofill rename Mar 5, 2026
@openshift-ci openshift-ci bot requested review from jgbernalp and zhuje March 5, 2026 17:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@PeterYurkovich PeterYurkovich changed the title OU-1242: dont autofill rename OU-1242: [release-coo-0.5] dont autofill rename Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@PeterYurkovich: This pull request references OU-1242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Bug Fixes
  • Fixed dashboard rename form reset behavior to properly clear the name field to empty state instead of restoring previous values when the form is closed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Mar 5, 2026

📝 Walkthrough

Walkthrough

Changed form handling in the dashboard rename modal: defaultValues.dashboardName is now an empty string; modal close calls form.reset({ dashboardName: '' }) instead of a full reset. Import list trimmed to remove getResourceDisplayName, retaining DashboardResource and getResourceExtendedDisplayName.

Changes

Cohort / File(s) Summary
Dashboard modal
web/src/components/dashboards/perses/dashboard-action-modals.tsx
Set RenameActionModal defaultValues.dashboardName to ''. On close, call form.reset({ dashboardName: '' }) instead of full reset. Removed getResourceDisplayName from imports; kept DashboardResource and getResourceExtendedDisplayName.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 I nudged a name box, tidy and small,
Erased the echoes that once would call,
Closed the modal, blank and bright—
A fresh name waits in morning light. ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title 'OU-1242: dont autofill rename' directly relates to the main change: preventing auto-fill behavior in the dashboard rename modal form by changing the dashboardName default value to an empty string.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@etmurasaki
Copy link
Contributor

etmurasaki commented Mar 5, 2026

tested with quay.io/rh-ee-pyurkovi/monitoring-console-plugin:OU-1242-0.5 and worked fine

image

@etmurasaki
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 5, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@PeterYurkovich: This pull request references OU-1242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Bug Fixes
  • Fixed dashboard rename form reset behavior to properly clear the name field to empty state instead of restoring previous values when the form is closed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@etmurasaki
Copy link
Contributor

/test ?

@etmurasaki
Copy link
Contributor

/test lint

@etmurasaki
Copy link
Contributor

/lgtm

@PeterYurkovich
Copy link
Contributor Author

/cherry-pick release-coo-0.5

@openshift-cherrypick-robot

@PeterYurkovich: once the present PR merges, I will cherry-pick it on top of release-coo-0.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-0.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2026

@PeterYurkovich: This pull request references OU-1242 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Bug Fixes

  • Fixed dashboard rename behavior so closing the rename dialog reliably clears the name field to an empty value instead of restoring previous input.

  • Chores

  • Minor internal cleanups with no change to public APIs or user-visible functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,etmurasaki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PeterYurkovich PeterYurkovich changed the title OU-1242: [release-coo-0.5] dont autofill rename OU-1242: dont autofill rename Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants