Add stdout logs including schollz progressbar on default verbosity 0#105
Add stdout logs including schollz progressbar on default verbosity 0#105Skalador wants to merge 3 commits intoopenshift:mainfrom
Conversation
Adding progressbar during the traversal. The traversal is run twice. Once during the pre obfuscation file scan and once on the obfuscation process. Consequently two progressbars will be printed during the must-gather-clean run. Also updating dependencies which come with schollz progressbar.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Skalador The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@Skalador: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Elbehery @tjungblu Before I go into the debugging on why the CI fails, I am curious on your take, if using https://github.com/schollz/progressbar/tree/main makes sense for us or not. There are quite a lot of dependencies just for the progressbar. If you have a different package in mind for the progressbar, please let me know. I am happy to adopt this proposal. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
Proposing the introduction of some logs on the default verbosity
-v0including a progressbar during the worker runs in the traversal. Consequently addressing #104. The traversal is run twice. Once during the pre obfuscation file scan and once on the obfuscation process. Consequently two progressbars will be printed during the must-gather-clean run. Also updating dependencies which come with schollz progressbar.Please find an output below: