Skip to content

Add stdout logs including schollz progressbar on default verbosity 0#105

Open
Skalador wants to merge 3 commits intoopenshift:mainfrom
Skalador:fix-issue-104
Open

Add stdout logs including schollz progressbar on default verbosity 0#105
Skalador wants to merge 3 commits intoopenshift:mainfrom
Skalador:fix-issue-104

Conversation

@Skalador
Copy link
Contributor

@Skalador Skalador commented Oct 14, 2025

Proposing the introduction of some logs on the default verbosity -v0 including a progressbar during the worker runs in the traversal. Consequently addressing #104. The traversal is run twice. Once during the pre obfuscation file scan and once on the obfuscation process. Consequently two progressbars will be printed during the must-gather-clean run. Also updating dependencies which come with schollz progressbar.

Please find an output below:

./must-gather-clean -c ../mgc/config.yaml -i ../mgc/must-gather.local.3611218946392327797 -o /tmp/mgc
I1014 14:33:44.465548    4088 cli.go:84] starting pre obfuscation file scan
Waiting for workers 100% [==============================================================================================================] (10/10) [0s]   
I1014 14:33:45.186258    4088 cli.go:96] starting obfuscation process
Waiting for workers 100% [=============================================================================================================] (10/10) [12s]   
I1014 14:34:02.757947    4088 cli.go:101] creating report
I1014 14:34:02.770949    4088 cli.go:109] creating watermark

Adding progressbar during the traversal. The traversal is run twice. Once during the pre obfuscation file scan and once on the obfuscation process. Consequently two progressbars will be printed during the must-gather-clean run. Also updating dependencies which come with schollz progressbar.
@openshift-ci openshift-ci bot requested review from Elbehery and tjungblu October 14, 2025 12:42
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skalador
Once this PR has been reviewed and has the lgtm label, please assign sairameshv for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 14, 2025

@Skalador: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit a49759e link true /test unit
ci/prow/e2e a49759e link true /test e2e
ci/prow/verify-deps a49759e link true /test verify-deps
ci/prow/verify a49759e link true /test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Skalador
Copy link
Contributor Author

Skalador commented Oct 14, 2025

@Elbehery @tjungblu Before I go into the debugging on why the CI fails, I am curious on your take, if using https://github.com/schollz/progressbar/tree/main makes sense for us or not. There are quite a lot of dependencies just for the progressbar. If you have a different package in mind for the progressbar, please let me know. I am happy to adopt this proposal.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2026
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants