Fix: Allow non-root users to run must-gather-clean#112
Fix: Allow non-root users to run must-gather-clean#112shoebvb-ibm wants to merge 1 commit intoopenshift:mainfrom
Conversation
Fixes openshift#111 This commit resolves the issue where non-root users cannot run must-gather-clean due to permission errors when attempting to chown newly created directories. Changes: - Modified pkg/fsutil/fsutil_unix.go to gracefully handle EPERM errors - Added error checking for syscall.EPERM and os.ErrPermission - Non-root users can now successfully run the tool without chown failures - Root users continue to preserve original file ownership as before The fix allows the tool to continue processing when chown operations fail due to insufficient privileges, which is expected behavior for non-root users. Files are still created with appropriate permissions for the current user, and obfuscation completes successfully. Tested on Linux and macOS with successful obfuscation of sample logs.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shoebvb-ibm The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @shoebvb-ibm. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 participant
Fixes #111
This commit resolves the issue where non-root users cannot run must-gather-clean due to permission errors when attempting to chown newly created directories.
Changes:
The fix allows the tool to continue processing when chown operations fail due to insufficient privileges, which is expected behavior for non-root users. Files are still created with appropriate permissions for the current user, and obfuscation completes successfully.
Tested on Linux and macOS with successful obfuscation of sample logs.