Skip to content

OSDOCS-13258: Update FlowCollector API 1.8#87820

Merged
skrthomas merged 1 commit intoopenshift:no-1.8from
skrthomas:OSDOCS-13258
Feb 13, 2025
Merged

OSDOCS-13258: Update FlowCollector API 1.8#87820
skrthomas merged 1 commit intoopenshift:no-1.8from
skrthomas:OSDOCS-13258

Conversation

@skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Jan 29, 2025

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

https://87820--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/flowcollector-api.html
QE review:

  • QE has approved this change.

Additional information:

Note to reviewers: This is auto-generated doc. Peer review comments may be addressed at the next release.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 29, 2025

@skrthomas
Copy link
Contributor Author

@skrthomas skrthomas changed the title OSDOCS-13258: Update FlowMetric API 1.8 OSDOCS-13258: Update FlowCollector API 1.8 Feb 6, 2025
@skrthomas skrthomas requested review from Amoghrd and jotak February 6, 2025 19:53
@skrthomas skrthomas added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

https://87820--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/flowcollector-api.html
QE review:

  • QE has approved this change.

Additional information:

Note to reviewers: This is auto-generated doc. Peer review comments may be addressed at the next release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mburke5678 mburke5678 added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Feb 7, 2025
@mburke5678
Copy link
Contributor

@skrthomas A few comments. Nice work here!
I know this is existing text, but the cell at lines 3197 to 3201is rendering as a blob, rather than a list. Is that something you could look at while in the file?

@mburke5678 mburke5678 added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 7, 2025
@mburke5678 mburke5678 added this to the Continuous Release milestone Feb 7, 2025
@skrthomas skrthomas force-pushed the OSDOCS-13258 branch 6 times, most recently from 77b3ba5 to 126a7a8 Compare February 10, 2025 20:10
@skrthomas
Copy link
Contributor Author

skrthomas commented Feb 10, 2025

Idk why this build is breaking. I've tried multiple things. Checking the master.xml file yields nothing helpful for what's wrong here. None of these work.

  • removing a carriage return after the +.
  • removing +
  • removing the IMPORTANT:
  • removing the brackets around Unsupported.

@skrthomas
Copy link
Contributor Author

/test validate-portal

@skrthomas skrthomas force-pushed the OSDOCS-13258 branch 2 times, most recently from ec5dc4e to 28511e2 Compare February 10, 2025 21:19
@skrthomas
Copy link
Contributor Author

skrthomas commented Feb 10, 2025

Turns out the Prow builds don't like the (*) parentheses around the asterisk. I'm pretty sure we had this in past iterations of the API docs so it must be that someone updated the build script to not allow this for some reason.

cc @jotak I removed the brackets and the parentheses around the * for all instances of [Unsupported (*)]

@openshift-ci
Copy link

openshift-ci bot commented Feb 11, 2025

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Amoghrd
Copy link

Amoghrd commented Feb 11, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 11, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 11, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

https://87820--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/flowcollector-api.html
QE review:

  • QE has approved this change.

Additional information:

Note to reviewers: This is auto-generated doc. Peer review comments may be addressed at the next release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skrthomas skrthomas merged commit 680468d into openshift:no-1.8 Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants