Skip to content

OSDOCS-13258: Update FlowMetrics API 1.8#87823

Merged
skrthomas merged 1 commit intoopenshift:no-1.8from
skrthomas:OSDOCS-13259
Feb 13, 2025
Merged

OSDOCS-13258: Update FlowMetrics API 1.8#87823
skrthomas merged 1 commit intoopenshift:no-1.8from
skrthomas:OSDOCS-13259

Conversation

@skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Jan 29, 2025

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 29, 2025
@skrthomas
Copy link
Contributor Author

@ocpdocs-previewbot
Copy link

@openshift-ci
Copy link

openshift-ci bot commented Jan 29, 2025

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skrthomas skrthomas requested review from Amoghrd and jotak February 6, 2025 19:53
@skrthomas skrthomas added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Amoghrd
Copy link

Amoghrd commented Feb 7, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DCChadwick
Copy link

/review @DCChadwick
/remove-label peer-review-needed
/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 7, 2025
Copy link

@DCChadwick DCChadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Just one sentence to clean up. Otherwise, it looks good to me.

@DCChadwick
Copy link

/remove-label peer-review-in-progress
/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 7, 2025
@skrthomas skrthomas merged commit 105494a into openshift:no-1.8 Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants