Skip to content

OSDOCS-13258: Flows Format Reference 1.8 update#87924

Merged
skrthomas merged 1 commit intoopenshift:no-1.8from
skrthomas:flows-format-reference-1.8
Feb 13, 2025
Merged

OSDOCS-13258: Flows Format Reference 1.8 update#87924
skrthomas merged 1 commit intoopenshift:no-1.8from
skrthomas:flows-format-reference-1.8

Conversation

@skrthomas
Copy link
Contributor

@skrthomas skrthomas commented Jan 31, 2025 •
edited
Loading

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

https://issues.redhat.com/browse/OSDOCS-13258
Link to docs preview:

https://87924--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/json-flows-format-reference.html
QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2025 •
edited by openshift-ci bot
Loading

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

Issue:

https://issues.redhat.com/browse/OSDOCS-13258
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2025
@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 31, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Jan 31, 2025 •
edited
Loading

🤖 Wed Feb 12 19:51:39 - Prow CI generated the docs preview:

https://87924--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/json-flows-format-reference.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Jan 31, 2025
View reviewed changes
@skrthomas
Copy link
Contributor Author

skrthomas commented Jan 31, 2025

/retest

@skrthomas
Copy link
Contributor Author

skrthomas commented Jan 31, 2025

netobserv/network-observability-operator#1071

@skrthomas skrthomas requested review from Amoghrd and jotak February 6, 2025 19:53
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

https://issues.redhat.com/browse/OSDOCS-13258
Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 7, 2025 •
edited by openshift-ci bot
Loading

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

https://issues.redhat.com/browse/OSDOCS-13258
Link to docs preview:

https://87924--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/json-flows-format-reference.html
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Amoghrd
Amoghrd reviewed Feb 7, 2025
View reviewed changes
@skrthomas skrthomas force-pushed the flows-format-reference-1.8 branch from f37c189 to 7121b7c Compare February 11, 2025 21:07
@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 11, 2025
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Feb 11, 2025
View reviewed changes
ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Feb 11, 2025
View reviewed changes
@skrthomas skrthomas force-pushed the flows-format-reference-1.8 branch 2 times, most recently from fa08ca8 to 9fb3cb4 Compare February 11, 2025 21:57
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 11, 2025
@skrthomas skrthomas force-pushed the flows-format-reference-1.8 branch from 9fb3cb4 to 383cfb8 Compare February 11, 2025 22:20
@Amoghrd
Copy link

Amoghrd commented Feb 12, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 12, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2025 •
edited by openshift-ci bot
Loading

@skrthomas: This pull request references OSDOCS-13258 which is a valid jira issue.

Details

In response to this:

Version(s):

To be merged only to no-1.8. At 2/25 GA, no-1.8 will be incorporated into 4.12+.
Issue:

https://issues.redhat.com/browse/OSDOCS-13258
Link to docs preview:

https://87924--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/network_observability/json-flows-format-reference.html
QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@skrthomas skrthomas added the peer-review-needed Signifies that the peer review team needs to review this PR label Feb 12, 2025
@skrthomas skrthomas added this to the Continuous Release milestone Feb 12, 2025
@cbippley
Copy link
Contributor

cbippley commented Feb 12, 2025

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Feb 12, 2025
cbippley
cbippley reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@cbippley cbippley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbippley
Copy link
Contributor

cbippley commented Feb 12, 2025

/label peer-review-done
/remove-label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Feb 12, 2025
@skrthomas skrthomas force-pushed the flows-format-reference-1.8 branch from 383cfb8 to ad0e80b Compare February 12, 2025 19:32
@skrthomas
Copy link
Contributor Author

skrthomas commented Feb 12, 2025

Addressed a lingering vale flag after peer review.

@openshift-ci
Copy link

openshift-ci bot commented Feb 12, 2025

@skrthomas: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@skrthomas skrthomas merged commit b98fc9d into openshift:no-1.8 Feb 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jotak jotak Awaiting requested review from jotak

3 more reviewers

@Amoghrd Amoghrd Amoghrd left review comments

@cbippley cbippley cbippley left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

6 participants

@skrthomas @openshift-ci-robot @ocpdocs-previewbot @Amoghrd @cbippley @ocpdocs-vale-bot