Refactor get_coredns_config (NE-2449): Use DynamicClient & testify/suite#151
Refactor get_coredns_config (NE-2449): Use DynamicClient & testify/suite#151bentito wants to merge 2 commits intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bentito The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
This refactors query_prometheus to use DynamicClient and NetEdgeTestSuite, aligning with PR openshift#151 and PR openshift#144. Moves query_prometheus to the netedge package to share test infrastructure. Signed-off-by: bentito <btofel@redhat.com>
|
@matzew I think this one is all set |
Add test case for missing ConfigMap 'data' map and ensure AddToScheme does not return an error in test setup. Signed-off-by: bentito <btofel@redhat.com>
|
@bentito: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
This PR refactors the
get_coredns_configtool introduced in #131 to align with the patterns established in #144.Changes:
controller-runtimeclient toDynamicClientfor consistency withinspect_route.testify/suitefor better grouping and setup logic.pkg/toolsets/netedge/suite_test.goto house the sharedNetEdgeTestSuite.This addresses feedback from @matzew regarding test grouping and client usage.
Related PRs:
get_coredns_config#131 (Introducedget_coredns_config)