Skip to content

[WIP] MG-216: add "openshift/mustgather" toolset#159

Draft
swghosh wants to merge 1 commit intoopenshift:mainfrom
swghosh:wg-must-gather-mcp-tools
Draft

[WIP] MG-216: add "openshift/mustgather" toolset#159
swghosh wants to merge 1 commit intoopenshift:mainfrom
swghosh:wg-must-gather-mcp-tools

Conversation

@swghosh
Copy link
Member

@swghosh swghosh commented Feb 25, 2026

Offline debugging analysis use cases require us to get data parsed from a must-gather archive rather than online cluster's kapiserver endpoint. Some tools are similar to the core toolset but there are more tools beyond resources_get especially journal logs, kubelet logs, etc.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Swarup Ghosh <swghosh@redhat.com>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 25, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: swghosh
Once this PR has been reviewed and has the lgtm label, please assign manusa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

// FindContainerDir locates the must-gather container directory
// (e.g., quay-io-okd-scos-content-sha256-...)
func FindContainerDir(basePath string) (string, error) {
entries, err := os.ReadDir(basePath)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a few considerations regarding where the must-gather can be stored:

  • if the server is running locally in a dev setup, it can access the must-gather from the fs
  • if it is running on the target cluster, we should probably make sure it can be read from a pv
  • the last one is variable where the must-gather needs to be accessed remotely. This will involve further discussions on where the must-gather from customer cases are stored and how they can be accessed.

@Cali0707
Copy link

/cc @bentito

Iirc you were also interested in the offline bits

@openshift-ci openshift-ci bot requested a review from bentito February 26, 2026 20:55
@swghosh swghosh changed the title WIP: add "openshift/mustgather" toolset [WIP] MG-216: add "openshift/mustgather" toolset Feb 27, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 27, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 27, 2026

@swghosh: This pull request references MG-216 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Offline debugging analysis use cases require us to get data parsed from a must-gather archive rather than online cluster's kapiserver endpoint. Some tools are similar to the core toolset but there are more tools beyond resources_get especially journal logs, kubelet logs, etc.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2026
@openshift-merge-robot
Copy link

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants