nodejs cartridge: use npm install --production

[Filirom1]

In the npm config doc it's explained that -d means --loglevel info.

Moreover,

By default, npm install will install all modules listed as dependencies. With the --production flag, npm will not install modules listed in devDependencies.

https://www.npmjs.org/doc/cli/npm-install.html

devDependencies are used for tests. We don't want to download tests dependencies when we deploy to openshift. It will make build faster for nodejs projects.

[danmcp]

[test]

[openshift-bot]

Online Test Results: FAILURE (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/8840/)

[mfojtik]

@danmcp @Filirom1 how about Jenkins, in case when users do want to run tests and for that they would need to install dev dependencies.... Can we make it configurable? Like --production as default but also ENV var, where you can set 'development' in case you want to run tests?

[Filirom1]

The JbossEWS cartridge skip test too.
https://github.com/openshift/origin-server/blob/master/cartridges/openshift-origin-cartridge-jbossews/bin/build#L53

Is there some convention for executing tests on jenkins?

[Filirom1]

Or I could use a NPM_ARGS environement variable, and if not defined I set it to --production --loglevel info

[danmcp]

@Filirom1 It would make sense to me to do similar to other carts and have a development and production type modes triggered by environment vars. Typically production is the default.

[openshift-bot]

Evaluated for online test up to 73484c6

[marvinroger]

Is there anything new? Applications these days have so much devDeps, with gulp, mocha, browserify, stylus, all this kind of stuff. Deploying litterally takes tens of minutes!