[SDCICD-1765] print cleanup errors in slack notification summary#3133
[SDCICD-1765] print cleanup errors in slack notification summary#3133varunraokadaparthi wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
There are test jobs defined for this repository which are not configured to run automatically. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: varunraokadaparthi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b46265 to
7354025
Compare
|
/lgtm |
7354025 to
4bceb3a
Compare
|
New changes are detected. LGTM label has been removed. |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@varunraokadaparthi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Slack notifications were only sent when cleanup reached the end of run. Any failure before that (e.g. config load, collect active clusters, VPC/IAM/S3 cleanup) caused an early return, so no summary was sent.
Fix: Send the summary from a defer so it runs on every exit. The summary includes whatever was collected so far and, on failure, appends the error. All failure paths now explicitly returnrunErr.