Skip to content

Remove ClusterRole/ClusterRoleBinding ci-operator-vpn from b02/04/08#75637

Open
liangxia wants to merge 1 commit intoopenshift:mainfrom
liangxia:ci-operator
Open

Remove ClusterRole/ClusterRoleBinding ci-operator-vpn from b02/04/08#75637
liangxia wants to merge 1 commit intoopenshift:mainfrom
liangxia:ci-operator

Conversation

@liangxia
Copy link
Member

@liangxia liangxia commented Mar 4, 2026

We do not support VPN on build02/04/08, so remove ClusterRole/ClusterRoleBinding ci-operator-vpn from them.
Also removed an empty line from several of the yaml files to make the configs for AWS clusters consistent.

$ ls -lh clusters/build-clusters/build*/ci-operator/*
-rw-r--r--. 1 lxia lxia 924 Mar  4 11:31 clusters/build-clusters/build01/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 924 Mar  4 11:31 clusters/build-clusters/build02/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 924 Dec 10 11:45 clusters/build-clusters/build03/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 924 Mar  4 11:31 clusters/build-clusters/build04/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build05/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build06/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build07/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build08/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build09/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build10/ci-operator/admin_ci-operator_rbac.yaml
-rw-r--r--. 1 lxia lxia 925 Mar  4 11:40 clusters/build-clusters/build11/ci-operator/admin_ci-operator_rbac.yaml

$ diff clusters/build-clusters/build01/ci-operator/admin_ci-operator_rbac.yaml clusters/build-clusters/build05/ci-operator/admin_ci-operator_rbac.yaml
19a20
> 

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liangxia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2026
@openshift-ci openshift-ci bot requested review from droslean and hector-vido March 4, 2026 03:44
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 4, 2026
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@liangxia: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 4, 2026

@liangxia: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@liangxia
Copy link
Member Author

liangxia commented Mar 4, 2026

/cc @openshift/test-platform

@openshift-ci openshift-ci bot requested a review from a team March 4, 2026 04:42
@Prucek
Copy link
Member

Prucek commented Mar 4, 2026

@liangxia this is something different. This is not related to the intranet capability. I think some people are still using it.
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants