OCPQE-31705: Add gangway support for overriding CPO image in hypershift-mce-agent-create-hostedcluster step

[zhfeng]

Summary

• Add OVERRIDE_CPO_IMAGE env var to hypershift-mce-agent-create-hostedcluster step to override the Control Plane Operator image via --annotations=hypershift.openshift.io/control-plane-operator-image
• Add MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_CPO_IMAGE env var for gangway API support
• Follows the same pattern as OVERRIDE_HO_IMAGE / MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_HO_IMAGE in the hypershift-mce-install step (Add gangway support for OVERRIDE_HO_IMAGE in hypershift-mce-install step #75628)

Usage

Via gangway API:

"pod_spec_options": {
  "envs": {
    "MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_CPO_IMAGE": "quay.io/hypershift/control-plane-operator:latest"
  }
}

Or via CI config:

env:
  OVERRIDE_CPO_IMAGE: quay.io/hypershift/control-plane-operator:latest

Test plan

• Trigger a periodic job via gangway with MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_CPO_IMAGE set
• Verify the annotation is passed to hcp create cluster agent command

Jira: https://issues.redhat.com/browse/OCPQE-31705

[openshift-ci-robot]

@zhfeng: This pull request references OCPQE-31705 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

• Add OVERRIDE_CPO_IMAGE env var to hypershift-mce-agent-create-hostedcluster step to override the Control Plane Operator image via --annotations=hypershift.openshift.io/control-plane-operator-image
• Add MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_CPO_IMAGE env var for gangway API support
• Follows the same pattern as OVERRIDE_HO_IMAGE / MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_HO_IMAGE in the hypershift-mce-install step (Add gangway support for OVERRIDE_HO_IMAGE in hypershift-mce-install step #75628)

Usage

Via gangway API:

"pod_spec_options": {
 "envs": {
   "MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_CPO_IMAGE": "quay.io/hypershift/control-plane-operator:latest"
 }
}

Or via CI config:

env:
 OVERRIDE_CPO_IMAGE: quay.io/hypershift/control-plane-operator:latest

Test plan

• Trigger a periodic job via gangway with MULTISTAGE_PARAM_OVERRIDE_OVERRIDE_CPO_IMAGE set
• Verify the annotation is passed to hcp create cluster agent command

Jira: https://issues.redhat.com/browse/OCPQE-31705

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhfeng
Once this PR has been reviewed and has the lgtm label, please assign jparrill for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• ci-operator/step-registry/hypershift/mce/agent/create/hostedcluster/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

[REHEARSALNOTIFIER]
@zhfeng: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name	Repo	Type	Reason
pull-ci-openshift-origin-release-4.16-e2e-agent-disconnected-ovn-dualstack-metal3	openshift/origin	presubmit	Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-ipv4-metal3	openshift/origin	presubmit	Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-agent-connected-ovn-dualstack-metal3	openshift/origin	presubmit	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-4.20-eus-upgrade-from-4.18-baremetalds-agent-hypershift-mce-inplace-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-4.16-upgrade-from-stable-4.15-baremetalds-agent-hypershift-mce-inplace-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-disconnected-ovn-ipv6-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-disconnected-guest-f14-des	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.16-periodics-mce-e2e-agent-critical	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-critical	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-n2minor-guest-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-baremetalds-hypershift-agent-mce-dualstack-guest-f14-des	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-critical	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.16-baremetalds-agent-hypershift-mce-mceupgrade-inplace-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-critical	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.16-baremetalds-agent-hypershift-mce-compact-full-inplace-f14	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.17-amd64-nightly-4.17-upgrade-from-stable-4.17-baremetalds-agent-hypershift-mce-inplace-f60	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.17-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.20-amd64-nightly-4.20-upgrade-from-stable-4.20-baremetalds-agent-hypershift-mce-inplace-f60	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-cilium-ipv4-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.19-periodics-mce-e2e-agent-disconnected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.18-amd64-nightly-4.18-eus-upgrade-from-4.16-baremetalds-agent-hypershift-mce-inplace-f28	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.18-periodics-mce-e2e-agent-connected-ovn-ipv4-manual-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-hypershift-release-4.20-periodics-mce-e2e-agent-connected-ovn-dualstack-metal-conformance	N/A	periodic	Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-amd64-nightly-baremetalds-hypershift-agent-mce-guest-f14	N/A	periodic	Registry content changed

A total of 123 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

[openshift-ci]

@zhfeng: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[zhfeng]

/pj-rehearse ack

[openshift-ci-robot]

@zhfeng: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.