mockgen deprecated: use uber-go/mock instead#443
mockgen deprecated: use uber-go/mock instead#443sebrandon1 wants to merge 1 commit intoopenshift:masterfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
=======================================
Coverage 55.57% 55.57%
=======================================
Files 30 30
Lines 2618 2618
=======================================
Hits 1455 1455
Misses 1074 1074
Partials 89 89
🚀 New features to boost your workflow:
|
|
@sebrandon1: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
/hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clcollins, sebrandon1 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
https://github.com/golang/mock is marked as archived as of
June 27, 2023. They recommend using go.uber.org/mock.This PR attempts to change the dependency to one that is maintained.
The changes to the
generated/files are because of the new library.Tracking issue: redhat-best-practices-for-k8s/telco-bot#45