Skip to content

Daemonset install without reboot #1349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Pacho20 wants to merge 4 commits into
base: devel
Choose a base branch
from
Draft

Daemonset install without reboot #1349

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b4fc5c5
daemonset deployment: prevent installation if NODE_LABEL envar is unset
Pacho20 Oct 29, 2025
7474625
daemonset deployment: migrate peer-pods config handling to osc-rpm Da…
Pacho20 Oct 29, 2025
47d28ac
daemonset deployment: enable Kata installation without node reboots
Pacho20 Oct 29, 2025
9c19cf2
logic to backup etc before uninstall
Pacho20 Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions scripts/kata-install/osc-kata-install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ main() {
exit 1
}

[[ -z "${NODE_LABEL:-}" ]] && {
Copy link
Contributor

@c3d c3d Nov 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the point of :- here?

Copy link
Contributor Author

@Pacho20 Pacho20 Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -u option is set, so if the variable is unset, it results in an error. Therefore, we don’t necessarily need :-, but using it allows us to set the variable to an empty string and thereby control the error message.

Copy link
Contributor

@c3d c3d Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant: You are adding a test to check if NODE_LABEL is not set, with an error message that essentially is a almost exactly what bash itself would give you.

I see no functional difference between

ERROR: NODE_LABEL env var must be set

and

NODEL_LABEL: unbound variable

So that code segment seems pointless to me.

Alternative: make the error message better, and send it to stderr instead of stdout.

echo "ERROR: NODE_LABEL env var must be set."
exit 1
}

#[[ -z "${LOG_LEVEL}" ]] || {
# echo "ERROR: LOG_LEVEL env var must be set."
# exit 1
Expand Down