Skip to content

Added Nepali months and weekdays strings for formatting#27

Merged
aj3sh merged 1 commit intoopensource-nepal:mainfrom
arjnep:nepaliMonth
Mar 26, 2025
Merged

Added Nepali months and weekdays strings for formatting#27
aj3sh merged 1 commit intoopensource-nepal:mainfrom
arjnep:nepaliMonth

Conversation

@arjnep
Copy link
Contributor

@arjnep arjnep commented Mar 22, 2025

Add

  • Nepali months for formatting
  • Nepali months for parsing
  • Weekdays for formatting (Half and Full)
  • Tests for the above

@aj3sh aj3sh requested review from aj3sh and sugat009 and removed request for aj3sh March 23, 2025 13:54
Copy link
Member

@aj3sh aj3sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @arjnep for your contribution. Your PR looks pretty good. I have added some feedback. Please have a look. :-)

@arjnep arjnep requested a review from aj3sh March 23, 2025 16:14
Copy link
Member

@aj3sh aj3sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @sugat009 Please review these changes.

@aj3sh aj3sh merged commit 438e0b1 into opensource-nepal:main Mar 26, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants