-
-
Notifications
You must be signed in to change notification settings - Fork 100
Remove Twitter links and embedded timeline #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Twitter links and embedded timeline #179
Conversation
|
Hi, I’ve removed the Twitter feed and related links as described. Please let me know if any further changes are needed. |
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except the one note about the removal of meta properties. :)
| <meta property="twitter:card" content="summary"> | ||
| <meta property="twitter:title" content="Open Source Diversity"> | ||
| <meta property="twitter:description" content="For more diversity & inclusion in free & open source software communities :)"> | ||
| <meta property="twitter:image" content="img/opensourcediversity-icon.png"> | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is metadata for when the website gets posted to Twitter, so this should stay. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve restored the Twitter meta tags in the head section as suggested. Thanks for the feedback!
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for the whitespace changes due to the removal and addition again it looks good. :) Approving
This PR removes references to the project's Twitter account:
img/twitter.svgVerified locally: