Mention new memory allocation routines in the coding style#113
Open
esyr wants to merge 2 commits intoopenssl:masterfrom
Open
Mention new memory allocation routines in the coding style#113esyr wants to merge 2 commits intoopenssl:masterfrom
esyr wants to merge 2 commits intoopenssl:masterfrom
Conversation
…rray [1] has introduced array allocation routines, and, since those are available, it is prudent to use where they are appropriate, like in this example. [1] openssl/openssl#28059 Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
Mention aligned, clear, and array allocation routines. Signed-off-by: Eugene Syromiatnikov <esyr@openssl.org>
paulidale
approved these changes
Aug 11, 2025
kroeckx
approved these changes
Aug 12, 2025
levitte
approved these changes
Aug 14, 2025
mattcaswell
approved these changes
Aug 15, 2025
esyr
referenced
this pull request
in openssl/openssl
Sep 3, 2025
This puts the style guide into the repository which is sort of the modern "norm". This has taken the text from the existing style guide in the web page and adapted it to how things will be with an automatic clang-format enforcement. What I have done is: - Referenced the Linux kernel style guide as the base we are using including the link to it. - Removed any reference to spacing, indenting, continuations, etc etc. which are contained in the Linux kernel style guide and enforced by clang-format. - Added a section on Integers. - Added a section for "new code" to Function return values preserving the existing advice for legacy code. - Added a secion on Header Files As I believe we can move to cleaner header files soon, this merely documents the expectation that I believe we can get to (clang-format does not yet do any header re-ordering)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.