fix(docs): DSPX-2409 replace SDK README code example with working code#3055
fix(docs): DSPX-2409 replace SDK README code example with working code#3055marythought wants to merge 3 commits intomainfrom
Conversation
Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
Summary of ChangesHello @marythought, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Code once broken, now made new, Docs updated, clear and true. SDK shines, a guiding light, For TDF, day and night. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly improves the SDK's README by replacing a broken code example with a fully functional and well-documented one. The new example is much clearer, follows best practices, and is aligned with the quickstart guide. The addition of prerequisites, configuration details, and expected output makes it much easier for new users to get started. I have one minor suggestion to improve the clarity of an authentication snippet.
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
310bd8c to
639e881
Compare
X-Test Failure Reportopentdf |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
Proposed Changes
Fixed Issues
mtls.NewGRPCAuthorizer(creds)functionNewTDFReader()toLoadTDF()and correctedCreateTDF()parametersImprovements to Example Code
https://opentdf.io/attr/department/value/financewhich is created in the quickstart guidesdk.WithInsecurePlaintextConn()for local developmentDocumentation Enhancements
Developer Experience
Checklist
Testing Instructions