[SIT] Move skip layers check to be before passing the tensor to the metrics#33960
Merged
svigh merged 3 commits intoopenvinotoolkit:masterfrom Feb 5, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the output layer skipping logic in the single-image-test tool by moving the filtering operation to a centralized location before tensors are passed to metric functions. Previously, each metric function (testRRMSE, testMAP, testNRMSE) implemented its own skip layer check, leading to code duplication.
Changes:
- Centralized skip layer filtering logic before metric function calls
- Removed duplicate skip layer checks from individual metric functions (testRRMSE, testMAP, testNRMSE)
- Applied minor formatting improvements to testSSDDetection function
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+3058
to
+3060
| std::vector<std::string> skipped_layers = splitStringList(FLAGS_skip_output_layers, ';'); | ||
| for (const auto& [tensorName, tensor] : outputTensors) { | ||
| if (std::find(skipped_layers.begin(), skipped_layers.end(), tensorName) != skipped_layers.end()) { |
There was a problem hiding this comment.
The linear search through skipped_layers is performed for every output tensor. Consider converting skipped_layers to an std::unordered_set for O(1) lookup performance, especially if there are many output layers or skipped layers.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
atamas19
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: