[core] [DRAFT] [IN PROGRESS] Make the internal implementation of Core.read_model(fs::path) the base implementation #33973
+123
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: inference
praasz
reviewed
Feb 6, 2026
| ov::frontend::InputModel::Ptr inputModel; | ||
|
|
||
| ov::AnyVector params{model_path}; | ||
| ov::AnyVector params{model_path.native()}; |
Contributor
There was a problem hiding this comment.
Suggested change
| ov::AnyVector params{model_path.native()}; | |
| ov::AnyVector params{model_path}; |
Frontend should handle path?
| #endif | ||
| params.emplace_back(weights_path); | ||
| if (!bin_path.empty()) { | ||
| params.emplace_back(bin_path.native()); |
Contributor
There was a problem hiding this comment.
Suggested change
| params.emplace_back(bin_path.native()); | |
| params.emplace_back(bin_path); |
…into almilosz/read_model_impl
almilosz
commented
Feb 9, 2026
| const auto devices = core.get_available_devices(); | ||
| const auto visitor = [&](const auto& param) { | ||
| using ParamT = std::decay_t<decltype(param)>; | ||
| auto folder = ov::test::utils::ensure_trailing_slash(ParamT(param)); |
Contributor
Author
There was a problem hiding this comment.
Is it crucial for UnicodePathTest, create_directories to test both "test_encoder/test_encoder.encrypted/", and "test_encoder/test_encoder.encrypted"? If yes, I think it's better to modify create_directories test, if no, test one of these options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: