Migrate connections protocol to a plugin#925
Migrate connections protocol to a plugin#925dbluhm wants to merge 9 commits intoopenwallet-foundation:mainfrom
Conversation
|
A corresponding PR will be opened to ACA-Py to remove the connections protocol. |
|
Functionality lost by moving connections protocol to a plugin (e.g. things we may wish to reinstate as a feature of this plugin, if there's enough desire for it):
Issues now resolved:
Things currently broken as a result of moving to a plugin (e.g. things we must fix to merge and have "good enough" feature parity):
|
|
Corresponding PR in ACA-Py: openwallet-foundation/acapy#3184 |
|
This plugin is dependent on changes in an unreleased version of ACA-Py but is otherwise ready for review. |
jamshale
left a comment
There was a problem hiding this comment.
Looks good to me.
I'd like to manually test it still and see if there should be anymore integration tests.
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
636de3d to
7fd565e
Compare
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
|
Can we merge this? |
|
@dbluhm Looks like this has become a priority again. Hoping it's not too much work to update. I think the testing is probably the worst because of the new testing profile. Probably easiest to copy them from acapy again. I had updated them all before they got removed recently. |
|
I'm short on time to address this one promptly -- I'd be happy to turn this over to someone else if they're available sooner than I am. Otherwise, I'll get to this as soon as I can, sorry. |
|
I can probably have a look at it soon. A little bit in limbo with webvh work atm. |
|
Closing in favor of #1447. |
This PR lifts the connections protocol out of ACA-Py proper and turns it into a plugin. The connections protocol has been deprecated for several releases. This completes the deprecation period while also encouraging the community to move on to bigger and better things (DID Exchange). But, for those who absolutely cannot move on, this plugin will fill the gap.
This is the first instance of a deprecated protocol entering retirement as a plugin. There may be processes to figure out still but I think it's time to make the jump.
Opening as draft while testing for input and thoughts.
cc @swcurran @jamshale