Skip to content

Basic browser detection and setting as query param in deeplink #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esune merged 12 commits into from
Mar 31, 2025
Merged

Basic browser detection and setting as query param in deeplink #746

Changes from 5 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df4461a
Basic browser detection and setting as query param in deeplink
Gavinok Mar 19, 2025
88ba8c4
Merge branch 'main' into detect-browser
Gavinok Mar 19, 2025
c237965
Correction to typo
Gavinok Mar 19, 2025
2bf388f
Clarify user agent logging
Gavinok Mar 20, 2025
213e3c7
Merge branch 'main' into detect-browser
Gavinok Mar 20, 2025
841d1c4
Migrate from cdn to static js file for ua-parser
Gavinok Mar 20, 2025
67f593d
Avoid using spaces in mobile browsers in deeplink
Mar 25, 2025
63615e3
Remove unused "supported browsers" section
Mar 27, 2025
ef2f17a
Handle edge case with Opera Mobile being encoded as "OPERA MOBI"
Mar 27, 2025
94b6bb0
Merge branch 'main' into detect-browser
Gavinok Mar 28, 2025
972428e
Switch from ? to & for deeplink query params
Mar 28, 2025
02117ef
Wrap all UAParser code in a try catch and fall back on regular deeplinks
Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions html-templates/verified_credentials.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ <h5 v-if="state.showScanned" class="fw-bolder mb-3">
<div>
<a
id="deep-link-button"
href="{{wallet_deep_link}}"
:href="combinedWalletLink"
class="btn btn-lg btn-block btn-primary w-100 mb-4 rounded-1"
title="Open BC Wallet"
target="_blank"
Expand Down Expand Up @@ -287,11 +287,15 @@ <h5 v-if="state.showScanned" class="fw-bolder mb-3">
</div>
</script>

<script src="https://cdn.jsdelivr.net/npm/ua-parser-js/dist/ua-parser.min.js"></script>
<script type="text/javascript">
const { createApp, ref, reactive, computed, watch } = Vue;
/**
/**
* @typedef {"intro" |"verified" | "failed" | "pending"| "expired" |"abandoned"} AppStates
*/
// user agent detection
const uap = new UAParser();
console.log(`Detected user agent: ${uap.getResult().browser.name}`)
const state = reactive({
/**
* @type {AppStates}
Expand Down Expand Up @@ -523,6 +527,12 @@ <h5 v-if="state.showScanned" class="fw-bolder mb-3">
required: true,
},
},
setup(props) {
const combinedWalletLink = computed(() => `{{wallet_deep_link}}?browser=${uap.getResult().browser.name}`);
return {
combinedWalletLink,
};
},
});
app.component("display-claims", {
template: `#display-claims`,
Expand Down