Update project dependencies and metadata to resolve Dependabot parsing errors#773
Closed
Gavinok wants to merge 1 commit intoopenwallet-foundation:mainfrom
Closed
Update project dependencies and metadata to resolve Dependabot parsing errors#773Gavinok wants to merge 1 commit intoopenwallet-foundation:mainfrom
Gavinok wants to merge 1 commit intoopenwallet-foundation:mainfrom
Conversation
Gavinok
force-pushed
the
dependabot-poetry-issue
branch
from
522cbd9 to
5ecc1a5
Compare
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com> - Updated dependencies in `pyproject.toml` to specify version ranges more explicitly. - Cleaned up formatting in the `pyproject.toml` file for better readability. - Removed unnecessary sections for pytest and Pyright configuration from `pyproject.toml`.
Gavinok
force-pushed
the
dependabot-poetry-issue
branch
from
5ecc1a5 to
f90a0bc
Compare
Pull Request Test Coverage Report for Build 15594757671Details
💛 - Coveralls |
esune
reviewed
Jun 12, 2025
Comment on lines
+14
to
+28
| requires-python = ">=3.12,<4.0" | ||
| dependencies = [ | ||
| "fastapi(>=0.115.12,<1.0)", | ||
| "jinja2(>=3.1.6,<4.0)", | ||
| "oic(>=1.7.0,<2.0)", | ||
| "pymongo(>=4.12.1,<5.0)", | ||
| "pyop(>=3.4.1,<4.0)", | ||
| "python-multipart(>=0.0.20,<1.0)", | ||
| 'qrcode[pil](>=8.2,<9.0)', | ||
| "structlog(>=25.3.0,<26.0.0)", | ||
| 'uvicorn[standard](>=0.34.2,<1)', | ||
| "python-socketio(>=5.13.0,<6.0.0)", | ||
| "canonicaljson(>=2.0.0,<3.0.0)", | ||
| "pydantic-settings (>=2.9.1,<3.0)", | ||
| ] |
Member
There was a problem hiding this comment.
I am not a fan of this style of dependency definition, it is a lot more dense and harder to scan when reviewing changes. I am also not convinced this is the issue: ACA-Py uses the same toml structure and gets similar warnings when running poetry check, and I am not aware of issues with dependencies there.
I do wonder if the problem is actually maybe with the lockfile and/or using different versions of poetry rather than pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update pyproject.toml file to pass the
poetry checkcommand which should be enough for dependabot to properly parse it resolving #740