Corrected dependabot path to pyproject.toml#774
Merged
esune merged 1 commit intoopenwallet-foundation:mainfrom Jun 13, 2025
Merged
Corrected dependabot path to pyproject.toml#774esune merged 1 commit intoopenwallet-foundation:mainfrom
esune merged 1 commit intoopenwallet-foundation:mainfrom
Conversation
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
loneil
reviewed
Jun 12, 2025
loneil
approved these changes
Jun 12, 2025
Pull Request Test Coverage Report for Build 15621761659Details
💛 - Coveralls |
esune
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As explained in #740
I think I've figured it out. The problem arises from https://github.com/Gavinok/vc-authn-oidc/blob/main/.github/dependabot.yml#L16-L26. Since it only looks in /oidc-controller for dependencies, it misses the pyproject.toml altogether.
Using the Dependabot CLI seems to identify multiple dependencies when starting at the root.
~/go/bin/dependabot update pip openwallet-foundation/acapy-vc-authn-oidc
In contrast, identifying a specific directory seems to provide no dependency info at all.
~/go/bin/dependabot update pip openwallet-foundation/acapy-vc-authn-oidc -d /oidc-controller
The solution is to have it check the root of the project for pip dependencies.