Chart for USE_CONNECTION_BASED_VERIFICATION variable#810
Merged
Conversation
Signed-off-by: Lucas ONeil <lucasoneil@gmail.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds configuration support for the USE_CONNECTION_BASED_VERIFICATION environment variable in the vc-authn-oidc Helm chart, allowing users to control whether the controller uses connection-based proofs or connectionless out-of-band invites.
- Adds a new configurable parameter
controller.useConnectionBasedVerificationwith a default value oftrue - Exposes the configuration as an environment variable in the deployment template
- Updates documentation to reflect the new parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/vc-authn-oidc/values.yaml | Adds the new useConnectionBasedVerification parameter with documentation and default value |
| charts/vc-authn-oidc/templates/deployment.yaml | Maps the parameter to the USE_CONNECTION_BASED_VERIFICATION environment variable |
| charts/vc-authn-oidc/README.md | Documents the new parameter in the configuration table |
Pull Request Test Coverage Report for Build 16508880044Details
💛 - Coveralls |
Gavinok
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE_CONNECTION_BASED_VERIFICATION maps from
controller.useConnectionBasedVerificationDefault
truebcgov/trust-over-ip-configurations#328