Skip to content

fix: handle missing optional nonce in issue_token_service #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esune merged 3 commits into from
Nov 28, 2025
Merged

fix: handle missing optional nonce in issue_token_service #907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a1be86
fix: handle missing optional nonce in issue_token_service
MonolithicMonk Nov 20, 2025
ab4f1a7
fix: handle missing optional nonce and improve proof format logic
MonolithicMonk Nov 20, 2025
1f549c9
Merge branch 'main' into fix/nonce-keyerror
esune Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions oidc-controller/api/core/oidc/issue_token_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,11 @@ def get_claims(
]
# subject claim

oidc_claims.append(
Claim(type="nonce", value=auth_session.request_parameters["nonce"])
)
# Conditionally append nonce as it is optional in Auth Code flow
if "nonce" in auth_session.request_parameters:
oidc_claims.append(
Claim(type="nonce", value=auth_session.request_parameters["nonce"])
)

presentation_claims: dict[str, Claim] = {}

Expand All @@ -69,12 +71,18 @@ def get_claims(
f"Configured proof format '{proof_format}' not found in record, falling back to 'anoncreds'"
)
proof_format = "anoncreds"
else:
# If we reach here, we have a data inconsistency or unsupported format
raise ValueError(
f"No valid proof format found in presentation exchange"
)

logger.info(
"Extracted requested attributes from presentation request",
requested_attributes=auth_session.presentation_exchange["pres_request"][
proof_format
]["requested_attributes"],
proof_format=proof_format,
)

referent: str
Expand Down
Loading