Skip to content

Ensure user_id is not null for in-memory userinfo storage#925

Merged
esune merged 6 commits intoopenwallet-foundation:mainfrom
esune:hotfix/v2.3.4-fix-user-id-rebased
Dec 1, 2025
Merged

Ensure user_id is not null for in-memory userinfo storage#925
esune merged 6 commits intoopenwallet-foundation:mainfrom
esune:hotfix/v2.3.4-fix-user-id-rebased

Conversation

@esune
Copy link
Member

@esune esune commented Nov 28, 2025

This PR addresses an issue that occurs when running VC-AuthN using the in-memory userinfo storage. The broken behaviour would try to fetch user info with an incorrect user_id, failing to complete the authentication flow and token issuance.

It also makes the single-pod mode run with in-memory storage by default, in order to simplify testing of redis-backed and in-memory storage backends.

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@esune esune requested review from Gavinok and loneil November 28, 2025 19:24
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@coveralls
Copy link

coveralls commented Nov 28, 2025

Pull Request Test Coverage Report for Build 19825355772

Details

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 87.716%

Totals Coverage Status
Change from base Build 19773199801: 0.005%
Covered Lines: 1928
Relevant Lines: 2198

💛 - Coveralls

@esune esune merged commit d3bee1c into openwallet-foundation:main Dec 1, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants