Logging for prover role#928
Merged
esune merged 19 commits intoopenwallet-foundation:mainfrom Jan 22, 2026
Merged
Conversation
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Pull Request Test Coverage Report for Build 21252760243Details
💛 - Coveralls |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Gavinok
force-pushed
the
logging-for-prover-role
branch
from
c8dd7e6 to
bd00880
Compare
Member
|
Will re-review after #917 is merged so we can see the diff related to this change only. It would be good to add documentation - likely a separate file under the |
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
esune
reviewed
Dec 22, 2025
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
- Updated Docker Compose configuration to use a new image for the issuer agent. - Refactored logging and methods in `bootstrap-trusted-verifier.py` to implement a mutual authentication pattern between the issuer and VC-AuthN. - Added comprehensive logging for each phase of the mutual authentication process. - Enhanced error handling and cleanup verification for presentation records. - Removed deprecated test logic related to prover role, focusing on the new mutual authentication approach. Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
- Update `post_topic` to delete presentation records for terminal states: "done", "abandoned", and "declined". - Implement error handling for deletion failures, logging appropriate messages for both failure cases and exceptions. - Add unit tests to verify deletion behavior for different states and ensure graceful handling of delete errors. Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
- Handle CONTROLLER_API_KEY being empty an empty string in the env file - Changed issuer-aca-py Docker image to `ghcr.io/openwallet-foundation/acapy-agent:py3.12-1.4.0`. - Removed the `ACAPY_AUTO_RESPOND_PRESENTATION_REQUEST` environment variable from the Docker configuration. Not needed for the issuer - Improved the `configureEnvironment` function in the manage script to use better condition checks for environment variables. - Added a new function `get_verifier_pres_ex_id` to retrieve the presentation exchange ID for the prover role in bootstrap script - Updated the prover role test to check if the VC-AuthN presentation cleanup is successful and log appropriate messages. - Enhanced error handling in cleanup verification process. Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
esune
reviewed
Jan 19, 2026
esune
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #898
This code should be merged after #917 as it relies on it to add the testing code to assist in testing and assigning the credential to the vc-auth acapy agent. This implementation uses the bootstrap script to also test this credential. This can be done with the following command.