Hotfix/record cleanup as thread#951
Merged
esune merged 4 commits intoopenwallet-foundation:mainfrom Jan 22, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 21220190930Details
💛 - Coveralls |
WadeBarnes
previously approved these changes
Jan 21, 2026
Contributor
|
@Gavinok, You are missing DCO on the second commit. Since the first two commits cancel each other out, it's best you rebase or squash the changes to remove them from the commit history. That will resolve the DCO issue at the same time. |
- Converted `_cleanup_presentation_records` and `_cleanup_connections` calls to run in a thread pool using `asyncio.to_thread()` to prevent blocking the event loop. - This change improves the overall responsiveness of the cleanup operation in the asynchronous environment. Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Gavinok
force-pushed
the
hotfix/record_cleanup_as_thread
branch
from
6e8ba38 to
ba88fee
Compare
- Updated docker environment file (.env.example) to clarify variables and improve comments. - Added a new test suite for the cleanup functionality to ensure it runs non-blocking. - Implemented tests to verify that cleanup runs in a thread pool, allowing the event loop to remain responsive. - Included assertions in tests to validate HTTP calls are performed in worker threads and that concurrent tasks can execute during cleanup. Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Signed-off-by: Gavin Jaeger-Freeborn <gavinfreeborn@gmail.com>
Contributor
Author
|
Long term this should be part of #863 and we should migrate away from requests to prevent other blocking related issues |
WadeBarnes
approved these changes
Jan 21, 2026
esune
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.