Follow up from Release 1.2.0 -- including LTS change#3432
Merged
swcurran merged 3 commits intoopenwallet-foundation:mainfrom Jan 9, 2025
swcurran:1.2.0-followup
Merged
Follow up from Release 1.2.0 -- including LTS change#3432swcurran merged 3 commits intoopenwallet-foundation:mainfrom swcurran:1.2.0-followup
swcurran merged 3 commits intoopenwallet-foundation:mainfrom
swcurran:1.2.0-followup
Conversation
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Signed-off-by: Stephen Curran <swcurran@gmail.com>
jamshale
previously approved these changes
Jan 9, 2025
Contributor
jamshale
left a comment
jamshale
left a comment
There was a problem hiding this comment.
The 0.12.lts branch would need to scan it's aries_cloudagent/** path for the source code. I haven't looked at this before. Maybe we can just add it here. Not sure what happens when it scans a path that doesn't exist.
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Contributor
Author
|
I think it is safe to add it in, since the referenced folder is not in the 0.12.lts branch and it hasn't complained. Curious now to see if there are other things found now that we've added that... |
jamshale
approved these changes
Jan 9, 2025
|
sownak
pushed a commit
to cheqd/aries-cloudagent-python
that referenced
this pull request
Jan 13, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Jan 29, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update references to the previous release follow the new 1.2.0 Release.
Update the snyk configuration to use the 1.2.lts branch.
@jamshale -- take a look at the snyk config. For the 0.12.lts branch, there is no
aries-agentpath. Should we add thearies-cloudagentpath that doesn't existin in main? I assume that is OK, since it has been working fine even though there is noaries-agentfolder in the 0.12.lts branch.