Add vcdm 2.0 model and context#3436
Merged
jamshale merged 29 commits intoopenwallet-foundation:mainfrom Feb 26, 2025
Merged
Conversation
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
… date with vcdm 1.1 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
ff137
reviewed
Jan 10, 2025
Member
ff137
left a comment
ff137
left a comment
There was a problem hiding this comment.
Just some early review comments
Contributor
|
@PatStLouis I think it might be wise to get this "basic" support merged and then worry about integration with DIDComm ICv2 and PPv2 in a future PR. |
Contributor
Author
|
@dbluhm I agree, I want at the minimum for the models not to break, since the didcomm protocols use the vc models |
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
…s-cloudagent-python into vcdm-2.0-data-model-support
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
…s-cloudagent-python into vcdm-2.0-data-model-support
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
Contributor
Author
|
@dbluhm ready for review |
dbluhm
reviewed
Feb 6, 2025
Contributor
dbluhm
left a comment
dbluhm
left a comment
There was a problem hiding this comment.
Quick comment but otherwise looks good
Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
|
dbluhm
approved these changes
Feb 25, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 27, 2025
* add vcdm 2.0 model and context Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add backwards compatibility checks: limit proof type and add issuance date with vcdm 1.1 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * seperate test fixtures, lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * replace issuanceDate tests Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * remove askar issuanceDate sorting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename credential context constant Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * updated linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * remove askar sorting step Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add vcdm 2.0 tests, fix presentation route default cryptosuite Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Fix broken tests, add v2 context to test document loader Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Debugging unit tests Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename test function to v2 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add list of support cryptosuites for vcdm 2.0 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add list of supported cryptosuites for vcdm 2.0 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * fix presentation fixture Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * fix created format check Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * fix tset fixtures Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add authentication proof purpose Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add holder proof type derivation when creating a vp Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> --------- Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
ff137
added a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 27, 2025
This reverts commit d736a48.
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 28, 2025
* add vcdm 2.0 model and context Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add backwards compatibility checks: limit proof type and add issuance date with vcdm 1.1 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * seperate test fixtures, lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * replace issuanceDate tests Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * remove askar issuanceDate sorting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename credential context constant Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * updated linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * remove askar sorting step Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add vcdm 2.0 tests, fix presentation route default cryptosuite Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Fix broken tests, add v2 context to test document loader Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * Debugging unit tests Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * rename test function to v2 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add list of support cryptosuites for vcdm 2.0 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add list of supported cryptosuites for vcdm 2.0 Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * fix presentation fixture Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * fix created format check Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * fix tset fixtures Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * lint Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add authentication proof purpose Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * add holder proof type derivation when creating a vp Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> * linting Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca> --------- Signed-off-by: PatStLouis <patrick.st-louis@opsecid.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs issuanceDate validation for vcdm 1.0 (add a current timestamp if absent)
Needs hooking up with didcomm