Support P256 keys & did:keys#3442
Merged
dbluhm merged 16 commits intoopenwallet-foundation:mainfrom Jan 15, 2025
Merged
Conversation
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
jamshale
reviewed
Jan 14, 2025
Contributor
jamshale
left a comment
jamshale
left a comment
There was a problem hiding this comment.
Looks well done to me 👍 Will let others get a chance to review.
ff137
requested changes
Jan 15, 2025
Member
ff137
left a comment
ff137
left a comment
There was a problem hiding this comment.
Overall pretty neat 👍
Just some recommendations for maintainability
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
ff137
previously approved these changes
Jan 15, 2025
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
|
ff137
approved these changes
Jan 15, 2025
dbluhm
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acapy_agent/wallet/keys/manager.py, removing some hardcoded ed25519 key types