Skip to content

Fixed handling of base wallet routes in auth decorator#3448

Merged
jamshale merged 3 commits intoopenwallet-foundation:mainfrom
esune:bugfix/base-wallet-routes-auth
Jan 16, 2025
Merged

Fixed handling of base wallet routes in auth decorator#3448
jamshale merged 3 commits intoopenwallet-foundation:mainfrom
esune:bugfix/base-wallet-routes-auth

Conversation

@esune
Copy link
Member

@esune esune commented Jan 16, 2025

Resolves #3445

Note: the handler was updated to accept both an array of strings or a space-separated list of strings, in order to prevent further disruption to existing deployments.

esune added 2 commits January 16, 2025 20:14
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
@esune esune requested review from dbluhm and jamshale January 16, 2025 20:18
@sonarqubecloud
Copy link

@jamshale jamshale merged commit f495a37 into openwallet-foundation:main Jan 16, 2025
11 checks passed
@esune esune deleted the bugfix/base-wallet-routes-auth branch January 16, 2025 21:39
ff137 pushed a commit to didx-xyz/acapy that referenced this pull request Jan 29, 2025
…undation#3448)

* Fixed handling of base wallet routes in auth decorator

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>

* Use multiple routes in test case

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>

---------

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com>
ff137 pushed a commit to didx-xyz/acapy that referenced this pull request Feb 13, 2025
…undation#3448)

* Fixed handling of base wallet routes in auth decorator

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>

* Use multiple routes in test case

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>

---------

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com>
ff137 pushed a commit to didx-xyz/acapy that referenced this pull request Feb 13, 2025
…undation#3448)

* Fixed handling of base wallet routes in auth decorator

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>

* Use multiple routes in test case

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>

---------

Signed-off-by: Emiliano Suñé <emiliano.sune@gmail.com>
Co-authored-by: jamshale <31809382+jamshale@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛--base-wallet-routes startup argument does not handle array of values correctly

2 participants