Prevent dummy profiles on start up#3449
Merged
jamshale merged 1 commit intoopenwallet-foundation:mainfrom Jan 17, 2025
Merged
Conversation
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Jan 29, 2025
Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
Signed-off-by: jamshale <jamiehalebc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't notice this before. I usually use multi-wallet mode.
When the get_profiles_from_storage() funtion was called on start up it was only using the main multitenant manager. This would cause dummy profiles to be created.
They didn't actually get used so I don't think its a huge problem other than it would create extra DB's if the deployment allowed it. Surprised it wasn't noticed until now :/