Pass the correct key for multitenant single wallets#3450
Merged
jamshale merged 2 commits intoopenwallet-foundation:mainfrom Jan 20, 2025
Merged
Pass the correct key for multitenant single wallets#3450jamshale merged 2 commits intoopenwallet-foundation:mainfrom
jamshale merged 2 commits intoopenwallet-foundation:mainfrom
Conversation
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Contributor
Author
|
The upgrade scenario test that Ian added a little while age would have caught this if it tested multitenancy. I'm going to create add this as a separate PR. |
|
ianco
approved these changes
Jan 20, 2025
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Jan 29, 2025
…ation#3450) Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…ation#3450) Signed-off-by: jamshale <jamiehalebc@gmail.com>
ff137
pushed a commit
to didx-xyz/acapy
that referenced
this pull request
Feb 13, 2025
…ation#3450) Signed-off-by: jamshale <jamiehalebc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For multitenant single wallet deployments the
multitenant_sub_walletneeds the admin key. I don't exactly know how I messed this up. I think, I thought that the subwallet key was blank because I was trying to fix a problem where it had been created with a blank key.This passes the admin wallet key to the subwallet and allows it to get rekey'd along with the admin wallet key.