:arrow_up: Upgrade dependencies by ff137 · Pull Request #3455 · openwallet-foundation/acapy

ff137 · 2025-01-20T18:19:27Z

Includes major upgrades, where I've eyeballed changelogs to confirm they don't include relevant breaking changes. We'll let the tests be the judge.

➖ Removes async-timeout, as it's been pulled into asyncio

⬆️ Upgrades:

deepmerge
jsonpath-ng
markupsafe
marhsmallow
packaging
portalocker
python-json-logger
qrcode
pre-commit
aiohttp-apispec-acapy

🎨 Resolves deprecation warnings

The only packages that remain outdated:
~~- apispec (6.6.1 vs 6.8.1)~~
~~- webargs (8.4.0 vs 8.6.0)~~

^ these are held back by aiohttp-apispec-acapy
@jamshale I've upgrade the fork to be more permissive for these dependencies, so they can be upgraded: https://github.com/ff137/aiohttp-apispec
Edit: thanks Jamie! Upgrade included

aries-askar (0.3.2 vs 0.4.1)
cached-property (1.5.2 vs 2.0.1)

^ held back by did-webvh, which needs more relaxed restriction on askar: decentralized-identity/didwebvh-py#18

prompt-toolkit (2.0.10 vs 3.0.50)
^ This is the only one that includes relevant breaking changes. Doesn't seem significant, but it requires some focus
(see https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/CHANGELOG -- 3.0.0 release: patch_stdout now requires an Application as input.)

jamshale

I'm happy to move forward on this but we need to get a patch release done before these changes go in. Will block until that is complete.

ff137 · 2025-01-20T19:42:46Z

Will also have to debug why agent in interop test doesn't start up

swcurran · 2025-01-21T15:35:21Z

We're seeing that happening in the Agent Test Harness tests as well - intermittent non-starting of the agent. Might be the issue.

No longer blocked...

ff137 · 2025-01-23T10:32:28Z

@swcurran I included unpinning of the remaining dependencies that were set to 1 specific version, and some last improvements. Which will hopefully help improve on that scorecard.

Tried upgrading to next marshmallow release, but 1 pytest broke, and didn't have time to dig into it now. So leaving marshmallow upgrade for later

edit: managed to figure out the Marshmallow change -- just a TypeError that needs to be handled in deserialization, to fix test that expects a specific error

jamshale · 2025-01-23T17:16:07Z

https://pypi.org/project/aiohttp-apispec-acapy/3.0.3/ Is now available with the unpinned dependencies if you want to include it in this PR.

async-timeout has been pulled into asyncio since python 3.11 Signed-off-by: ff137 <ff137@proton.me>

Includes major upgrades without breaking changes Signed-off-by: ff137 <ff137@proton.me>

Signed-off-by: ff137 <ff137@proton.me>

Remove deprecated field (order is now preserved by default) Handle new TypeError Signed-off-by: ff137 <ff137@proton.me>

Signed-off-by: ff137 <ff137@proton.me>

Fixes: `ChangedInMarshmallow4Warning: Returning `False` from a validator is deprecated. Raise a `ValidationError` instead.` Signed-off-by: ff137 <ff137@proton.me>

Signed-off-by: ff137 <ff137@proton.me>

ff137 · 2025-01-23T17:54:10Z

https://pypi.org/project/aiohttp-apispec-acapy/3.0.3/ Is now available with the unpinned dependencies if you want to include it in this PR.

Awesome, thank you! Included

One step closer to running with 3.13 👀

edit: just got saw all PR tests pass in python3.13 🚀

sonarqubecloud · 2025-01-23T17:57:03Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
66.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jamshale

Looks good to me and tests are all passing so should be safe 👍

jamshale · 2025-01-23T18:06:06Z

acapy_agent/messaging/jsonld/tests/test_routes.py


+    async def asyncTearDown(self):
+        # Ensure the event loop is closed
+        await self.profile.close()


* ➖ Remove deprecated package async-timeout has been pulled into asyncio since python 3.11 Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade dependencies Includes major upgrades without breaking changes Signed-off-by: ff137 <ff137@proton.me> * 📌 Unpin dependency versions Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade pre-commit Signed-off-by: ff137 <ff137@proton.me> * 🎨 Fix deprecation warning - module moved Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade marshmallow Remove deprecated field (order is now preserved by default) Handle new TypeError Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Update lock file Signed-off-by: ff137 <ff137@proton.me> * 🎨 Resolve Marshmallow deprecation warning Fixes: `ChangedInMarshmallow4Warning: Returning `False` from a validator is deprecated. Raise a `ValidationError` instead.` Signed-off-by: ff137 <ff137@proton.me> * 🎨 Fix pytest-asyncio warning: unclosed event loop Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade aiohttp-apispec-acapy Signed-off-by: ff137 <ff137@proton.me> * ⬆️ Upgrade pydevd-pycharm Signed-off-by: ff137 <ff137@proton.me> --------- Signed-off-by: ff137 <ff137@proton.me>

jamshale previously requested changes Jan 20, 2025

View reviewed changes

ff137 marked this pull request as draft January 20, 2025 19:42

ff137 marked this pull request as ready for review January 21, 2025 15:41

jamshale self-requested a review January 22, 2025 18:09

ff137 force-pushed the update-deps branch from 8eeaa33 to 6497d69 Compare January 23, 2025 14:01

ff137 added 10 commits January 23, 2025 19:48

➖ Remove deprecated package

47c8950

async-timeout has been pulled into asyncio since python 3.11 Signed-off-by: ff137 <ff137@proton.me>

⬆️ Upgrade dependencies

9041f98

Includes major upgrades without breaking changes Signed-off-by: ff137 <ff137@proton.me>

📌 Unpin dependency versions

6113cd4

Signed-off-by: ff137 <ff137@proton.me>

⬆️ Upgrade pre-commit

fd7db16

Signed-off-by: ff137 <ff137@proton.me>

🎨 Fix deprecation warning - module moved

75de181

Signed-off-by: ff137 <ff137@proton.me>

⬆️ Upgrade marshmallow

9f138e8

Remove deprecated field (order is now preserved by default) Handle new TypeError Signed-off-by: ff137 <ff137@proton.me>

⬆️ Update lock file

51ac8ea

Signed-off-by: ff137 <ff137@proton.me>

🎨 Resolve Marshmallow deprecation warning

c14d41e

Fixes: `ChangedInMarshmallow4Warning: Returning `False` from a validator is deprecated. Raise a `ValidationError` instead.` Signed-off-by: ff137 <ff137@proton.me>

🎨 Fix pytest-asyncio warning: unclosed event loop

e1284f0

Signed-off-by: ff137 <ff137@proton.me>

⬆️ Upgrade aiohttp-apispec-acapy

551bced

Signed-off-by: ff137 <ff137@proton.me>

ff137 force-pushed the update-deps branch from 6497d69 to 551bced Compare January 23, 2025 17:48

⬆️ Upgrade pydevd-pycharm

38e1ddb

Signed-off-by: ff137 <ff137@proton.me>

jamshale approved these changes Jan 23, 2025

View reviewed changes

jamshale merged commit d93518f into openwallet-foundation:main Jan 23, 2025
11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⬆️ Upgrade dependencies#3455

⬆️ Upgrade dependencies#3455
jamshale merged 11 commits intoopenwallet-foundation:mainfrom
didx-xyz:update-deps

ff137 commented Jan 20, 2025 •

edited

Loading

Uh oh!

jamshale left a comment

Uh oh!

ff137 commented Jan 20, 2025

Uh oh!

swcurran commented Jan 21, 2025

Uh oh!

ff137 commented Jan 23, 2025 •

edited

Loading

Uh oh!

jamshale commented Jan 23, 2025

Uh oh!

ff137 commented Jan 23, 2025 •

edited

Loading

Uh oh!

sonarqubecloud bot commented Jan 23, 2025 •

edited

Loading

Uh oh!

jamshale left a comment

Uh oh!

jamshale Jan 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ff137 commented Jan 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamshale left a comment

Choose a reason for hiding this comment

Uh oh!

ff137 commented Jan 20, 2025

Uh oh!

swcurran commented Jan 21, 2025

Uh oh!

ff137 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jamshale commented Jan 23, 2025

Uh oh!

ff137 commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Jan 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Quality Gate passed

Uh oh!

jamshale left a comment

Choose a reason for hiding this comment

Uh oh!

jamshale Jan 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ff137 commented Jan 20, 2025 •

edited

Loading

ff137 commented Jan 23, 2025 •

edited

Loading

ff137 commented Jan 23, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 23, 2025 •

edited

Loading