feat: Remove issuance v1 protocols

[jamshale]

This removes the v1 issuance protocols in favor of a plugin. See #3252 for original work.

The plugin PR openwallet-foundation/acapy-plugins#2288 uses this to re-enable v1 issuance support.

When this is finished and successful the same method will be used for the presentation v1 protocols.

[Copilot]

Pull request overview

This pull request removes the v1 issuance protocols from ACA-Py core in favor of a plugin-based approach. The removal is part of a larger effort to modularize the codebase and allow v1 protocols to be optionally added via plugins when needed.

Key Changes:

• Complete removal of v1.0 issue credential protocol implementation
• Updates to tests and examples to use v2.0 protocols instead
• Addition of event bus handling in v2.0 routes for credential revocation
• Simplification of revocation manager by removing v1-specific logic

Reviewed changes

Copilot reviewed 56 out of 63 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
scenarios/examples/connectionless/example.py	Removed v1 credential issuance example function (icv1), keeping only v2
scenarios/examples/connectionless/docker-compose.yml	Changed log level from debug to info for alice and bob agents
acapy_agent/utils/tests/test_tracing.py	Updated imports and tests to use V20CredExRecord instead of V10CredentialExchange
acapy_agent/revocation/tests/test_manager.py	Updated tests to use v2 models, removed v1-specific test cases
acapy_agent/revocation/manager.py	Removed v1/v2 credential exchange state updates from set_cred_revoked_state method
acapy_agent/protocols/present_proof/v1_0/tests/test_manager.py	Updated import to use v2 credential record for state constant
acapy_agent/protocols/out_of_band/v1_0/tests/test_manager.py	Removed v1 credential offer tests and imports
acapy_agent/protocols/out_of_band/v1_0/manager.py	Removed v1 credential exchange lookup, now only supports v2
acapy_agent/protocols/issue_credential/v2_0/tests/test_routes.py	Added comprehensive tests for new event bus integration
acapy_agent/protocols/issue_credential/v2_0/routes.py	Added register_events and cred_revoked functions for event handling
acapy_agent/protocols/issue_credential/v1_0/*	Deleted entire v1.0 protocol directory including routes, handlers, managers, models, messages, and all tests
acapy_agent/core/tests/test_goal_code_registry.py	Updated import to reference v2 CONTROLLERS instead of v1

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jamshale]

The interop tests are expected to fail without the plugin installed.

Here is a branch using this PR and installing the plugin. openwallet-foundation/owl-agent-test-harness#919

The tests are passing with this branch and the plugin installed.

[jamshale]

This should be the only reference for issue-credential/1.0. I wasn't able to think of a way to inject it into this class without maybe an ugly monkey patch of the function in the plugin.

[jamshale]

This is a main change. The revocation is done via event handler in the routes file now.

[jamshale]

This is where the revocation is handled now for the cred_ex record. The plugin has the same thing for V1 IssuerCredRevRecords's.

[esune]

Looking good, thank you @jamshale for cleaning this up 👍🏻
It will be nice to start shedding some old code 🙂

[jamshale]

I'd like to get approval on the plugin PR before merging this. openwallet-foundation/acapy-plugins#2288.

[esune]

I'd like to get approval on the plugin PR before merging this. openwallet-foundation/acapy-plugins#2288.

On it, going through it currently

[PatStLouis]

@jamshale don't we want to remove the associated bdd tests and have those live in the plugin repo instead?

[jamshale]

@jamshale don't we want to remove the associated bdd tests and have those live in the plugin repo instead?

You're right. I forgot to remove the BDD tests in the repo. I'll do that. They only run on nightly and release runs.

We have a basic test for coverage in the plugin PR and a few tests in the OATH project which we can keep. No need to remove those.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jamshale]

So I'm pretty sure all the v1 protocol bdd tests were already removed from the acapy repo. I think this is good to go.

[esune]

The failing integration tests are the Kanon ones that I believe we're dragging along currently. It however looks like some BDD tests are failing as well - they are related to the issue-credential steps so will need to get checked.

Code changes were already approved 👍🏻

[jamshale]

The failing integration tests are the Kanon ones that I believe we're dragging along currently. It however looks like some BDD tests are failing as well - they are related to the issue-credential steps so will need to get checked.

Code changes were already approved 👍🏻

The BDD Interop tests are the test harness repo tests. They are expected to fail until the plugin is installed. I have tested OATH with this branch and the plugin installed and the tests all pass. I'll update it after merging this and the plugin.