Skip to content

fix(kanon):updated connection cleanup to share 1 thread and added logging to detect connection leakage #3963

Merged
jamshale merged 19 commits intoopenwallet-foundation:mainfrom
VeriDID:cleanup-calls
Dec 10, 2025
Merged

fix(kanon):updated connection cleanup to share 1 thread and added logging to detect connection leakage #3963
jamshale merged 19 commits intoopenwallet-foundation:mainfrom
VeriDID:cleanup-calls

Conversation

@vinaysingh8866
Copy link
Contributor

No description provided.

…ar and kanon db

Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
… to close soon

Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
@vinaysingh8866 vinaysingh8866 force-pushed the cleanup-calls branch 2 times, most recently from 8202c3e to 0f843aa Compare November 27, 2025 23:48
Signed-off-by: Vinay Singh <vinay@verid.id>
Signed-off-by: Vinay Singh <vinay@verid.id>
@jamshale
Copy link
Contributor

jamshale commented Dec 3, 2025

Although this doesn't seem to completely resolve the problem (failed on the 7th run in github actions), it looks like there's a lot of improvement here, especially around logging and helping to better determine the root of the problem when it occurs.

@vinaysingh8866 I think we should merge it, but I'm unable to update the branch.

@vinaysingh8866
Copy link
Contributor Author

@jamshale it seems the params on the docker file are incorrect.
I have updated it another dev from our team is looking at the test configuration.

@jamshale
Copy link
Contributor

jamshale commented Dec 9, 2025

I'll merge this if we get it updated with main again. There's enough useful debugging and connection management improvements that it's worth it even if there's another source of the failures.

@vinaysingh8866
Copy link
Contributor Author

@jamshale we need to add logs to the docker container, when a test fails it should show all the logs of the container.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
69.8% Coverage on New Code (required ≥ 80%)
6.4% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@jamshale
Copy link
Contributor

Ok. Lets merge this so it doesn't get behind and I can do that.

@jamshale jamshale merged commit 97f3412 into openwallet-foundation:main Dec 10, 2025
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants