fix: encode revocation tag in tails upload URL (issue 1580)#3996
Conversation
Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #1580 by URL-encoding revocation registry IDs in tails file upload and public URLs to handle special characters like whitespace in revocation tags.
Key Changes:
- URL-encode the filename parameter using
urllib.parse.quote()withsafe=":"to preserve Indy identifier structure - Update existing tests to expect encoded URLs
- Add new test case specifically for revocation tags containing whitespace
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| acapy_agent/tails/indy_tails_server.py | Adds URL encoding for filenames in both upload and public URLs using quote(filename, safe=":") |
| acapy_agent/tails/tests/test_indy.py | Updates test assertions to expect encoded URLs and adds comprehensive test for revocation tags with whitespace |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for your contribution. I think this is good and will approve. You do need to fix the DCO check. There's some instructions for fixing this in the action details. https://github.com/openwallet-foundation/acapy/pull/3996/checks?check_run_id=58834216130 |
Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
47b6a8b to
862b22a
Compare
Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
862b22a to
303d6f4
Compare
|
@jamshale Thank you. I have fixed DCO sign off. |
|



Fix Summary
Fix Testing