Skip to content

fix: encode revocation tag in tails upload URL (issue 1580)#3996

Merged
jamshale merged 5 commits intoopenwallet-foundation:mainfrom
sonivijayk:sonivijayk/fix/issue-1580-revocation-tag-whitespace
Jan 5, 2026
Merged

fix: encode revocation tag in tails upload URL (issue 1580)#3996
jamshale merged 5 commits intoopenwallet-foundation:mainfrom
sonivijayk:sonivijayk/fix/issue-1580-revocation-tag-whitespace

Conversation

@sonivijayk
Copy link
Contributor

Fix Summary

  • URL-encode revocation registry id when building tails upload/public URLs
  • Add test coverage for revocation tags containing whitespace

Fix Testing

  • Ran python -m pytest acapy_agent/tails/tests/test_indy.py

Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes issue #1580 by URL-encoding revocation registry IDs in tails file upload and public URLs to handle special characters like whitespace in revocation tags.

Key Changes:

  • URL-encode the filename parameter using urllib.parse.quote() with safe=":" to preserve Indy identifier structure
  • Update existing tests to expect encoded URLs
  • Add new test case specifically for revocation tags containing whitespace

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
acapy_agent/tails/indy_tails_server.py Adds URL encoding for filenames in both upload and public URLs using quote(filename, safe=":")
acapy_agent/tails/tests/test_indy.py Updates test assertions to expect encoded URLs and adds comprehensive test for revocation tags with whitespace

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jamshale
Copy link
Contributor

Thanks for your contribution. I think this is good and will approve.

You do need to fix the DCO check. There's some instructions for fixing this in the action details. https://github.com/openwallet-foundation/acapy/pull/3996/checks?check_run_id=58834216130

Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
@sonivijayk sonivijayk force-pushed the sonivijayk/fix/issue-1580-revocation-tag-whitespace branch from 47b6a8b to 862b22a Compare January 4, 2026 05:27
Vijay Soni added 2 commits January 3, 2026 23:37
Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
Signed-off-by: Vijay Soni <vijaysoni@sonivijay.com>
@sonivijayk sonivijayk force-pushed the sonivijayk/fix/issue-1580-revocation-tag-whitespace branch from 862b22a to 303d6f4 Compare January 4, 2026 06:06
@sonivijayk
Copy link
Contributor Author

@jamshale Thank you. I have fixed DCO sign off.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2026

@jamshale jamshale merged commit 80ededd into openwallet-foundation:main Jan 5, 2026
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants