feat: Only log failing scenarios#4005
Merged
jamshale merged 3 commits intoopenwallet-foundation:mainfrom Dec 31, 2025
Merged
Conversation
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
|
esune
approved these changes
Dec 31, 2025
Member
esune
left a comment
esune
left a comment
There was a problem hiding this comment.
Good idea, I did not think about over-logging problems, this is definitely welcome so we won't have to be digging in neverending logs
sonivijayk
pushed a commit
to sonivijayk/acapy
that referenced
this pull request
Jan 3, 2026
* feat: Only log failing scenarios Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix: Remove silent mode Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
sonivijayk
pushed a commit
to sonivijayk/acapy
that referenced
this pull request
Feb 18, 2026
* feat: Only log failing scenarios Signed-off-by: jamshale <jamiehalebc@gmail.com> * fix: Remove silent mode Signed-off-by: jamshale <jamiehalebc@gmail.com> --------- Signed-off-by: jamshale <jamiehalebc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging for the scenario tests is quite extensive. It would be better for diagnosing the reason for failures if it only displayed the container logs of the failing scenario.