-
Notifications
You must be signed in to change notification settings - Fork 533
1.5.0rc0 #4011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.5.0rc0 #4011
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,16 +42,16 @@ Click [here](https://github.com/openwallet-foundation/acapy/pkgs/container/acapy | |
|
|
||
| The following is the ACA-Py container images tagging format: | ||
|
|
||
| **Regular Releases** (e.g., publishing version `1.4.0`): | ||
| - `pyV.vv-X.Y.Z` - Python version specific tag (e.g., `py3.12-1.4.0`) | ||
| - `X.Y.Z` - Semantic version tag (e.g., `1.4.0`) | ||
| - `X.Y` - Major.minor version tag (e.g., `1.4`), automatically moves to the latest patch release | ||
| - `latest` - Automatically assigned to the highest semantic version (non-RC) release | ||
|
|
||
| **Release Candidates** (e.g., publishing version `1.4.0-rc1`): | ||
| - `pyV.vv-X.Y.Z-rcN` - Python version specific RC tag (e.g., `py3.12-1.4.0-rc1`) | ||
| - `X.Y.Z-rcN` - Semantic version RC tag (e.g., `1.4.0-rc1`) | ||
| - **Note**: RC releases do NOT receive major.minor (`X.Y`) or `latest` tags | ||
| **Regular Releases** (e.g., `1.5.0`): | ||
| - `py3.12-1.5.0` - Python version specific tag | ||
| - `1.5.0` - Semantic version tag | ||
| - `1.5` - Major.minor tag (moves to latest patch release) | ||
| - `latest` - Only assigned if this is the highest semantic version | ||
|
|
||
| **Release Candidates** (e.g., `1.5.0-rc0`): | ||
| - `py3.12-1.5.0-rc0` - Python version specific RC tag | ||
| - `1.5.0-rc0` - Semantic version RC tag | ||
| - **Note**: RC releases do NOT receive major.minor (`1.5`) or `latest` tags | ||
|
Comment on lines
+46
to
+54
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was meant to use generic versions to avoid having to update this file with every release, since it is just documentation. If we want to keep it aligned with the latest released version this is fine, but thought to point it out.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Understood. Part of the publishing process (documented in PUBLISHING.md) is to find all of the references to the version to both change because they must (e.g. pyproject.toml) or should (SupportedRFCs.md) or to see if they are still accurate (e.g. LTS versions, etc.). The list was pretty small up to now so easy. These additions just add more and so I've got to decide if it is useful to keep them up to date so we can decide per release if they are still relevant. Probably not is my leaning. |
||
|
|
||
| **Nightly Builds**: | ||
| - `pyV.vv-nightly-YYYY-MM-DD` - Date-stamped nightly build | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note that this should maybe be 1.5.0rc0
also re:
I believe that the hyphen is required for official semantic versioning, whereas python convention doesn't require the hyphen and drops it for python versioning
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation discrepancy may originate from me updating the docs and using strict semantic versioning as @ff137 noted. I think we can either update the docs and keep tagging with the pattern we used so far (I don;t think the new publish action would complain), or deploy docker images using stricter semantic versioning, but that would cause discrepancies.
However, if
PUBLISHING.mdis used as a step-by-step guide to release it might be worth leaving some information to check the tagging process was successful and proceeded as expected?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The question is really what those instances of versions refer to and precisely what is the format of each instance of "version". If they refer to GitHub or PyPi tags, then they need to be fixed. If (as I assume from the context) they refer to GHCR container image tags, then they need to be verified that the "-" is really present -- which is what I was asking.