Skip to content

DIF presentation debug logging#4019

Merged
jamshale merged 4 commits intoopenwallet-foundation:mainfrom
nodlesh:fix/DIF-PE2-for-CTS
Jan 13, 2026
Merged

DIF presentation debug logging#4019
jamshale merged 4 commits intoopenwallet-foundation:mainfrom
nodlesh:fix/DIF-PE2-for-CTS

Conversation

@nodlesh
Copy link
Contributor

@nodlesh nodlesh commented Jan 12, 2026

Summary

  • Kept a compact verification summary at DEBUG and gated detailed verification results behind debug.presentations.
  • Added a sanitizer (_summarize_doc_result) that omits full documents/proofs.
  • Added a unit test to ensure sensitive fields are not logged.

Key changes

  • DEBUG‑level logs for create/search/verify for DIF presentation‑exchange
  • Detailed verification results only when debug.presentations is enabled
  • New test: test_summarize_doc_result_redacts_sensitive_fields

These logs are useful when debugging DIF verification (verified=false with no detail). This change keeps the signal while respecting sensitive data and existing debug.presentations behavior.

Detailed logs only emitted when --debug-presentations is enabled.

Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
@swcurran
Copy link
Contributor

@nodlesh -- can you please address the Ruff / Lint checks? Should be easy enough.

@jamshale -- are the PR tests a real issue?

Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Signed-off-by: Sheldon Regular <sheldon.regular@gmail.com>
Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm confused why sonarcloud is reporting no coverage but it's not a big deal for this PR.

@jamshale jamshale enabled auto-merge (squash) January 13, 2026 21:12
@jamshale jamshale merged commit 0267a94 into openwallet-foundation:main Jan 13, 2026
10 checks passed
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants