fix(utils): satisfy Sonar S7497 in timeout shim#4060
Merged
PatStLouis merged 3 commits intoopenwallet-foundation:mainfrom Feb 20, 2026
Merged
fix(utils): satisfy Sonar S7497 in timeout shim#4060PatStLouis merged 3 commits intoopenwallet-foundation:mainfrom
PatStLouis merged 3 commits intoopenwallet-foundation:mainfrom
Conversation
…l TimeoutError) Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
…y (fixes Sonar S7497) Signed-off-by: Patrick St-Louis <patrick.st-louis@opsecid.ca>
jamshale
approved these changes
Feb 20, 2026
|
swcurran
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the post-merge Sonar failure in
acapy_agent/utils/repeat.py(python:S7497). The compatibility shim forasyncio.timeout(Python <3.11) was catchingasyncio.CancelledErrorand raisingTimeoutError, which Sonar flags becauseCancelledErrormust be re-raised after cleanup.Changes
python = "^3.13"), soasyncio.timeoutis always available. The fallback that usedcall_later+CancelledErrorwas dead code and was the only code path triggering S7497._timeout_cm()now always returnsasyncio.timeout(duration)and the unusedasynccontextmanagerimport is removed.Resolves
Post-merge Sonar scan failure: "Ensure that the asyncio.CancelledError exception is re-raised after your cleanup code" at L107 in
acapy_agent/utils/repeat.py.