Skip to content

Comments

Add support for affinity/tolerations to pre-delete hook job#297

Merged
qrkourier merged 1 commit intoopenziti:mainfrom
aditmeno:main
Feb 13, 2025
Merged

Add support for affinity/tolerations to pre-delete hook job#297
qrkourier merged 1 commit intoopenziti:mainfrom
aditmeno:main

Conversation

@aditmeno
Copy link
Contributor

@aditmeno aditmeno commented Feb 10, 2025

Allow pre-delete-hook job to inherit the affinity and tolerations set in the values file

@aditmeno aditmeno changed the title Add support for affinity/tolerations to and remove repeated labels from pre-delete hook Add support for affinity/tolerations to and remove repeated labels from pre-delete hook job Feb 10, 2025
@qrkourier qrkourier self-requested a review February 10, 2025 22:36
@qrkourier
Copy link
Member

Thanks for the patch. Will you say more about the problem with kustomize?

It seems like the chart should retain the ability to accept arbitrary labels.

@aditmeno
Copy link
Contributor Author

aditmeno commented Feb 13, 2025

Thanks for the patch. Will you say more about the problem with kustomize?

It seems like the chart should retain the ability to accept arbitrary labels.

Yes since {{- include "zrok.labelsFrontend" . | nindent 8 }} contains the labels which are already defined in the in the template

Ah, you updated it upstream, thanks!

@aditmeno aditmeno changed the title Add support for affinity/tolerations to and remove repeated labels from pre-delete hook job Add support for affinity/tolerations to pre-delete hook job Feb 13, 2025
@qrkourier
Copy link
Member

you updated it upstream

Yes! I suspect that another user encountered the same problem with Kustomize, and sent a slightly different patch that answered my question about the collision. Thanks, again.

Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
@qrkourier qrkourier merged commit d8219bc into openziti:main Feb 13, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants