Add support for affinity/tolerations to pre-delete hook job#297
Merged
qrkourier merged 1 commit intoopenziti:mainfrom Feb 13, 2025
Merged
Add support for affinity/tolerations to pre-delete hook job#297qrkourier merged 1 commit intoopenziti:mainfrom
qrkourier merged 1 commit intoopenziti:mainfrom
Conversation
Member
|
Thanks for the patch. Will you say more about the problem with kustomize? It seems like the chart should retain the ability to accept arbitrary labels. |
Contributor
Author
Yes since Ah, you updated it upstream, thanks! |
Member
Yes! I suspect that another user encountered the same problem with Kustomize, and sent a slightly different patch that answered my question about the collision. Thanks, again. |
qrkourier
approved these changes
Feb 13, 2025
Signed-off-by: Aditya Menon <amenon@canarytechnologies.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow pre-delete-hook job to inherit the affinity and tolerations set in the values file